Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update designing-api.md #313

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update designing-api.md #313

wants to merge 2 commits into from

Conversation

shiv19
Copy link

@shiv19 shiv19 commented May 26, 2024

Adds a missing typescript definition

Adds a missing typescript definition
Copy link

vercel bot commented May 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
capacitor-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 26, 2024 3:55am

Removed the `& PluginListenerHandle` part as it no longer conforms to the latest capacitor core api.
Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR, but there are several other things that changed on the plugin types since this tutorial was created that are also out of date, and also on the table, can you update those too?

@shiv19
Copy link
Author

shiv19 commented Aug 8, 2024

Sure, I can take a look at this next week.
I'll be away this weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants