Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(google-maps): @googlemaps/js-api-loader: Refactor to importLibrary method #1587

Closed
wants to merge 1 commit into from
Closed

feat(google-maps): @googlemaps/js-api-loader: Refactor to importLibrary method #1587

wants to merge 1 commit into from

Conversation

AE1NS
Copy link
Contributor

@AE1NS AE1NS commented May 9, 2023

Closes #1586

@AE1NS AE1NS force-pushed the maps-api-instance-check branch from 17d8c7e to cbf61a3 Compare May 9, 2023 06:22
@AE1NS AE1NS changed the title fix(google-maps): Added ability for plugin to take already instanciat… feat(google-maps): Added ability for plugin to take already instanciat… May 9, 2023
@AE1NS AE1NS changed the title feat(google-maps): Added ability for plugin to take already instanciat… feat(google-maps): Added ability for plugin to take already instanciated google maps api May 17, 2023
@AE1NS AE1NS force-pushed the maps-api-instance-check branch 4 times, most recently from 06cd6a5 to 7e215e7 Compare May 23, 2023 07:19
@AE1NS AE1NS force-pushed the maps-api-instance-check branch from 7e215e7 to 4895b4a Compare May 25, 2023 15:18
@AE1NS AE1NS force-pushed the maps-api-instance-check branch from 4895b4a to d37682f Compare June 19, 2023 14:12
@AE1NS AE1NS force-pushed the maps-api-instance-check branch from d37682f to efa1d87 Compare July 4, 2023 13:21
@AE1NS AE1NS changed the title feat(google-maps): Added ability for plugin to take already instanciated google maps api feat(google-maps): @googlemaps/js-api-loader: Refactor to importLibrary method Jul 4, 2023
@AE1NS AE1NS force-pushed the maps-api-instance-check branch from efa1d87 to e07002d Compare July 28, 2023 05:17
@AE1NS AE1NS force-pushed the maps-api-instance-check branch from e07002d to 553e198 Compare March 1, 2024 11:00
@AE1NS
Copy link
Contributor Author

AE1NS commented Mar 3, 2024 •
edited
Loading

This is a minor but effective adjustment. What do you think about it? We are already using this in production for months and its the only way how we can use other google apis like geolocation or directions in parallel.

rkitin pushed a commit to rkitin/capacitor-google-maps that referenced this pull request Apr 27, 2024
@rcherukuri-sta
feat(google-maps): @googlemaps/js-api-loader: Refactor to importLibra…
aa2ffea 
…ry method

ionic-team/capacitor-plugins#1587
@AE1NS
Copy link
Contributor Author

AE1NS commented Jun 18, 2024

Moved ionic-team/capacitor-google-maps#21

@AE1NS AE1NS closed this Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[@capacitor/google-maps] @googlemaps/js-api-loader: Refactor to importLibrary method
2 participants
@AE1NS @A1Jan