feat(filesystem): Add support for SDCard filesystem on Android#1665
Open
ghenry22 wants to merge 14 commits intoionic-team:mainfrom
Open
feat(filesystem): Add support for SDCard filesystem on Android#1665ghenry22 wants to merge 14 commits intoionic-team:mainfrom
ghenry22 wants to merge 14 commits intoionic-team:mainfrom
Conversation
add isPortableStorageAvailable to check is SD Card is present add Directory.PortableStorage to select the SD Card directory
ghenry22
changed the title
ghenry22
changed the title
ghenry22
changed the title
giralte-ionic
requested review from
IT-MikeS,
ItsChaceD,
giralte-ionic,
jcesarmobile,
markemer and
theproducer
giralte-ionic
added
the
type: feature request
Author
|
@giralte-ionic any chance of getting this reviewed and merged? It's non breaking, fully backward compatible and simply adds support to the filesystem plugin on android for accessing storage on the SD card when the card is configured as Portable Storage. |
Author
|
Any chance of getting this merged in an upcoming release? Being able to access the SDCARD filesystem using the standard filesystem plugin is useful for anyone storing or accessing files on Android. |
This comment was marked as abuse.
This comment was marked as abuse.
|
Are there any plans for this to become a feature of the plugin? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for checking and accessing the SD Card on Android.
add isPortableStorageAvailable() to check if SD Card is present
add Directory.PortableStorage to select the SD Card directory
Tested on simulator on Android 9
Tested on Samsung Galaxy S10 on Android 10
Tested on Samsung Galaxy A23 5G on Android 13
Tested on Google Pixel 6a (no SD card slot on device, confirming all works in this scenario)
This is non-breaking and backward compatible.
closes ionic-team/capacitor-filesystem#36