fix(android): run downloadFile asynchronously #2287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Released dev build of filesystem with dev version: 7.0.0-dev-2287-20241220T140459.0 |
alexgerardojacinto
approved these changes
Dec 23, 2024
Comment on lines
+310
to
+311
| public void downloadFile(PluginCall call, Bridge bridge, HttpRequestHandler.ProgressEmitter emitter, | ||
| FilesystemDownloadCallback callback) throws IOException, URISyntaxException, JSONException { |
There was a problem hiding this comment.
I believe this method no longer throws the mentioned exceptions, but rather returns them in FilesystemDownloadCallback, therefore we should update the signature
Suggested change
| public void downloadFile(PluginCall call, Bridge bridge, HttpRequestHandler.ProgressEmitter emitter, | |
| FilesystemDownloadCallback callback) throws IOException, URISyntaxException, JSONException { | |
| public void downloadFile(PluginCall call, Bridge bridge, HttpRequestHandler.ProgressEmitter emitter, | |
| FilesystemDownloadCallback callback) { |
Comment on lines
+317
to
+324
| AsyncTaskResult result = doDownloadInBackground(urlString, call, bridge, emitter); | ||
| handler.post(() -> { | ||
| if (result.error != null) { | ||
| callback.onError(result.error); | ||
| } else { | ||
| callback.onSuccess(result.result); | ||
| } | ||
| }); |
There was a problem hiding this comment.
It seems to me that it is unnecessary to have this AsyncTaskResult, since it either just wraps the result or error if it exists.
I feel like we could lift the try-catch out of doDownloadInBackground, and have it return the JSObject directly
Suggested change
| AsyncTaskResult result = doDownloadInBackground(urlString, call, bridge, emitter); | |
| handler.post(() -> { | |
| if (result.error != null) { | |
| callback.onError(result.error); | |
| } else { | |
| callback.onSuccess(result.result); | |
| } | |
| }); | |
| try { | |
| JSObject result = doDownloadInBackground(urlString, call, bridge, emitter); | |
| handler.post(() -> callback.onSuccess(result)); | |
| } catch (Exception error) { | |
| handler.post(() -> callback.onError(error)); | |
| } |
Also, if you do this change, add the throws IOException, URISyntaxException, JSONException to the doDownloadInBackground signature.
What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6861
This PR runs
downloadFilein an async task so it does not block other plugin calls.