fix(android): prevent crash on script injection if the script is too …

…long (#7316) Co-authored-by: Alex Ryltsov <3608222+ryaa@users.noreply.github.com> Co-authored-by: Mark Anderson <mark@ionic.io>
ionic-team · Mar 6, 2024 · 67c00e2 · 67c00e2
1 parent 28e7f08
commit 67c00e2
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/android/capacitor/src/main/java/com/getcapacitor/JSInjector.java b/android/capacitor/src/main/java/com/getcapacitor/JSInjector.java
@@ -69,12 +69,17 @@ public String getScriptString() {
      * @return
      */
     public InputStream getInjectedStream(InputStream responseStream) {
-        String js = "<script type=\"text/javascript\">" + getScriptString().replace("${", "\\${") + "</script>";
+        String js = "<script type=\"text/javascript\">" + getScriptString() + "</script>";
         String html = this.readAssetStream(responseStream);
+
+        // Insert the js string at the position after <head> or before </head> using StringBuilder
+        StringBuilder modifiedHtml = new StringBuilder(html);
         if (html.contains("<head>")) {
-            html = html.replaceFirst("<head>", "<head>\n" + js + "\n");
+            modifiedHtml.insert(html.indexOf("<head>") + "<head>".length(), "\n" + js + "\n");
+            html = modifiedHtml.toString();
         } else if (html.contains("</head>")) {
-            html = html.replaceFirst("</head>", js + "\n" + "</head>");
+            modifiedHtml.insert(html.indexOf("</head>"), "\n" + js + "\n");
+            html = modifiedHtml.toString();
         } else {
             Logger.error("Unable to inject Capacitor, Plugins won't work");
         }