Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(android): Allow plugin methods to crash #2512

Merged
merged 1 commit into from
Mar 4, 2020

Conversation

jcesarmobile
Copy link
Member

Since Capacitor uses reflection it was catching any exception the reflection could cause, but that was also hiding any possible crash a plugin might have and make it impossible for crash reporters such as Crashlytics to report those issues.

This PR changes the invoke exception handling to not catch InvocationTargetException nor IllegalAccessException, and throw them as a RuntimeException

closes #2150

@jcesarmobile jcesarmobile merged commit 253cdc9 into ionic-team:master Mar 4, 2020
@jcesarmobile jcesarmobile deleted the allow-exceptions branch March 4, 2020 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant