feat(android): Allow plugin methods to crash #2512
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Capacitor uses reflection it was catching any exception the reflection could cause, but that was also hiding any possible crash a plugin might have and make it impossible for crash reporters such as Crashlytics to report those issues.
This PR changes the
invoke
exception handling to not catchInvocationTargetException
norIllegalAccessException
, and throw them as aRuntimeException
closes #2150