Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cordova-plugin-screen-orientation support #1062

Merged
merged 1 commit into from
Dec 21, 2018

Conversation

jcesarmobile
Copy link
Member

Add preferredInterfaceOrientationForPresentation and supportedInterfaceOrientations to make view controller rotation configurable and add supportedOrientations array that makes the configuration possible from cordova-plugin-screen-orientation.

Will also read current configuration from info.plist file

Closes #1061

@jcesarmobile jcesarmobile requested a review from mlynch December 19, 2018 18:54
@mlynch mlynch merged commit 046d4dd into ionic-team:master Dec 21, 2018
@jcesarmobile jcesarmobile deleted the screen-orientation branch December 21, 2018 18:18
@bitflower
Copy link

Any plans here for a merge/release?

@spun-Chris
Copy link

Any further updates on the merge/release?

@bitflower
Copy link

This works for me since months.

@spun-Chris
Copy link

I still have the same error as before the fix. Below is my current set up, is there anything in there that conflicts or needs updating? Thanks for your help!

Ionic:

Ionic CLI : 5.4.4 (/usr/local/lib/node_modules/ionic)
Ionic Framework : @ionic/angular 4.0.0
@angular-devkit/build-angular : 0.12.3
@angular-devkit/schematics : 7.2.3
@angular/cli : 7.2.3
@ionic/angular-toolkit : 1.3.0

Capacitor:

Capacitor CLI : 1.3.0
@capacitor/core : 1.3.0

Cordova:

Cordova CLI : 9.0.0 (cordova-lib@9.0.1)
Cordova Platforms : none
Cordova Plugins : no whitelisted plugins (0 plugins total)

Utility:

cordova-res : not installed
native-run : not installed

System:

NodeJS : v13.0.1 (/usr/local/bin/node)
npm : 6.12.0
OS : macOS Mojave
Xcode : Xcode 11.1 Build version 11A1027

@ionic-team ionic-team locked as off-topic and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

screen orientation lock does not work on iOS 12.x (ionic 4 with capacitor)
4 participants