Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): call webview.load on main thread on setServerBasePath #1967

Merged
merged 1 commit into from
Sep 16, 2019

Conversation

jcesarmobile
Copy link
Member

No description provided.

@jcesarmobile jcesarmobile merged commit d7def71 into ionic-team:master Sep 16, 2019
@jcesarmobile jcesarmobile deleted the main-load branch September 16, 2019 15:36
@naranjamecanica
Copy link
Contributor

Hi,

I know you're working very hard and I'm very grateful for this project, but could you write some (short) explanation why these changes where made? If I find strange behaviour I walk trough the history of commits and see if I can find anything why something is happening.

thanks again and cheers! 👍
Martijn

@jcesarmobile
Copy link
Member Author

Because plugin methods are executed in a background thread, but webview.load is required to be executed in the main thread and Xcode shows a runtime warning when doing it in a background thread.

@naranjamecanica
Copy link
Contributor

Thank you!! If it's possible to give every commit some context would be super!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants