-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(android): add group and groupSummary to LocalNotifications #2385
feat(android): add group and groupSummary to LocalNotifications #2385
Conversation
3033485
to
b7b88ab
Compare
I'm not able to make this work, can you maybe provide a sample app where I can easily test it? Also, core-plugin-definitions.ts have now conflicts (probably because I merged your iOS PR). Can you fix it and also document that those are Android only and a brief description (for the 4 new options) |
b7b88ab
to
a27a52d
Compare
a27a52d
to
ef7134a
Compare
@jcesarmobile Here is a demo app I threw together: https://github.com/p7g/capacitor-android-group-demo Just run it in the android emulator, send some notifications with a group name, and then send a groupSummary notification with the same group (I put a text box and some buttons on the page). That's essentially the use-case I have. |
Thanks for the sample app, I got it working. You have removed |
Whoops, didn't mean to remove those, I've added them back. |
can you also add the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
And thanks for making all the changes
This PR adds
group
andgroupSummary
options inLocalNotifications.schedule()
, which allows you to group notifications together on Android.I noticed a TODO comment in
LocalNotificationManager.Build
for groups, which says to implementsetGroup
,setGroupSummary
, andsetNumber
. This PR only implements the first 2, should I also addsetNumber
?