Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(capacitor): make switch statements exhaustive #3135

Closed
wants to merge 3 commits into from
Closed

fix(capacitor): make switch statements exhaustive #3135

wants to merge 3 commits into from

Conversation

danielsogl
Copy link
Contributor

fixes: #3134

@imhoffd imhoffd mentioned this pull request Jun 24, 2020
Closed
@imhoffd imhoffd requested a review from ikeith June 24, 2020 19:21
@imhoffd
Copy link
Contributor

imhoffd commented Jun 24, 2020

@danielsogl It looks like the iOS build is failing for this PR, would you be able to look into it?

@danielsogl
Copy link
Contributor Author

@dwieeb I think the error is exclusive to iOS 14 because the new given options are not available for iOS 13.

@ikeith
Copy link
Contributor

ikeith commented Jun 24, 2020

Yes, the additional cases will break compilation under previous versions of Xcode. This needs some #available checks to conditionally reference the new cases only when building with the beta(s).

@danielsogl
Copy link
Contributor Author

I will update the PR

ikeith
ikeith reviewed Jun 24, 2020
View reviewed changes
ios/Capacitor/Capacitor/Plugins/Permissions.swift
}

#endif
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This #endif needs to be moved up. When compiled out, it's breaking the brackets on the switch statement.

@ikeith ikeith mentioned this pull request Jun 25, 2020
Merged
@ikeith
Copy link
Contributor

ikeith commented Jun 25, 2020

After some examination, the problem is a bit more complicated. I've opened a new PR, #3160, to clean things up with the enums. Please feel free to comment on that if you have any concerns.

@ikeith ikeith closed this Jun 25, 2020
@danielsogl danielsogl deleted the patch-4 branch June 25, 2020 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikeith ikeith ikeith left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: Switch must be exhaustive (Xcode 12)
3 participants
@danielsogl @imhoffd @ikeith