Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(iOS): Add base implementation of permissions calls #3856

Merged
merged 5 commits into from
Nov 24, 2020
Merged

feat(iOS): Add base implementation of permissions calls #3856

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
53ec2c7
Adding stub implementations of permissions calls to the plugin base c…
ikeith Nov 24, 2020
3af70ce
Match formatting to rest of the file.
ikeith Nov 24, 2020
a8b43bf
Merge branch 'main' into ios-permissions
imhoffd Nov 24, 2020
8346655
Merge branch 'main' into ios-permissions
ikeith Nov 24, 2020
e170384
Merge branch 'main' into ios-permissions
ikeith Nov 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ios/Capacitor/Capacitor/CAPPlugin.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,11 @@
- (void)addListener:(CAPPluginCall* _Nonnull)call;
- (void)removeListener:(CAPPluginCall* _Nonnull)call;
- (void)removeAllListeners:(CAPPluginCall* _Nonnull)call;
/**
* Default implementation of the capacitor 3.0 permission pattern
*/
- (void)checkPermissions:(CAPPluginCall* _Nonnull)call;
- (void)requestPermissions:(CAPPluginCall* _Nonnull)call;
/**
* Give the plugins a chance to take control when a URL is about to be loaded in the WebView.
* Returning true causes the WebView to abort loading the URL.
Expand Down
8 changes: 8 additions & 0 deletions ios/Capacitor/Capacitor/CAPPlugin.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,14 @@ - (BOOL)hasListeners:(NSString *)eventName {
return [listeners count] > 0;
}

- (void)checkPermissions:(CAPPluginCall *)call {
[call resolve];
}

- (void)requestPermissions:(CAPPluginCall *)call {
[call resolve];
}

/**
* Configure popover sourceRect, sourceView and permittedArrowDirections to show it centered
*/
Expand Down