Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added common dependencies variables #447

Closed

Conversation

jcesarmobile
Copy link
Member

Related to #227

I've been having a lot of problems with Cordova plugins setting 27+ for android support libraries. There is a conflict as we set it to 26.1.0.

So this is my idea, I've created a dependencies.gradle file in the template with the common cordova variable names set to a value that works for us. I apply it in the project build.gradle so it's accesible to all modules. This file won't be overwritten by us, it's for the user to manage, he can also add his own variables there.

This is just the initial step, next steps should be

  1. Remove the CLI code that changes the plugin variables with a default version, it should leave the variable names and then gradle will take care of it.
  2. Document the dependencies.gradle so users know what it is and how to use it.
  3. Edit the app template, plugin template, capacitor android, etc, to use those variables instead of fixed values.

@mlynch WDYT?

@nerdic-coder
Copy link

This would be great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants