feat(ios): Add overrideable routing for CAPBridgeViewController subclasses #5546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
struct. Using an _ prefix is a common pattern for non-public types in the Swift standard library.
Steven0351
commented
Mar 29, 2022
| } | ||
|
|
||
| // swiftlint:disable:next type_name | ||
| internal struct _Router: Router { |
There was a problem hiding this comment.
I disabled the swiftlint violation here because this is common practice in the Swift standard library to use an _ prefix for non-public types
There was a problem hiding this comment.
I'm fine with naming it something different if that's what we want to do as well.
jcesarmobile
approved these changes
Mar 30, 2022
giralte-ionic
approved these changes
Mar 30, 2022
This was referenced Apr 25, 2022
This was referenced Jun 1, 2022
This was referenced Jul 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.