Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): prevent error on migrate when devDependencies is missing #5863

Merged
merged 1 commit into from
Aug 17, 2022
Merged

Conversation

zookatron
Copy link
Contributor

Currently the "cap migrate" command will crash with the error "Failed to migrate: TypeError: Cannot convert undefined or null to object" if you run it in project that has a package.json file without a devDependencies property. This PR fixes this issue.

Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, thanks!

@jcesarmobile jcesarmobile changed the title Fix crash on migrate command when devDependencies is missing fix(cli): prevent error on migrate when devDependencies is missing Aug 17, 2022
@jcesarmobile jcesarmobile merged commit 474ad1f into ionic-team:main Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants