fix(cli): apkName for multi-dimensional flavors #6704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienfdev
changed the title
markemer
requested review from
jcesarmobile,
ItsChaceD,
IT-MikeS,
giralte-ionic and
theproducer
markemer
requested changes
Jul 28, 2023
|
Just did, changed my 3 edited files, sorry for the oversight ! |
markemer
approved these changes
Jul 31, 2023
giralte-ionic
approved these changes
Aug 21, 2023
|
Why is this PR not merged? I could use this feature :-) |
|
I am having this problem, I hope they merge it soon |
This comment was marked as abuse.
This comment was marked as abuse.
|
@markemer Hello, will support be added for the build command? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the apkName problem with multi dimensional flavors on Android.
Discussed here > #6703