Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ios): Add xcprivacy manifest #7314

Closed
wants to merge 5 commits into from
Closed

chore(ios): Add xcprivacy manifest #7314

wants to merge 5 commits into from

Conversation

Steven0351
Copy link
Contributor

No description provided.

jcesarmobile
jcesarmobile reviewed Mar 6, 2024
View reviewed changes
Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should probably also add the file for the CapacitorCordova project as there are a lot of chances that Apple confuses it with Cordova and flags the file as missing

@Steven0351
Copy link
Contributor Author

good call

@Steven0351 Steven0351 requested a review from jcesarmobile March 6, 2024 16:11
jcesarmobile
jcesarmobile reviewed Mar 6, 2024
View reviewed changes
ios/CapacitorCordova/CapacitorCordova/PrivacyInfo.xcprivacy Outdated
Comment on lines 3 to 9
<!--
PrivacyInfo.xcprivacy
CapacitorCordova

Created by Steven Sherry on 3/6/24.
Copyright (c) 2024 jcesarmobile. All rights reserved.
-->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want copyright of this 😓

This is the actual cordova file, if that helps, instead of being empty it includes some values set to false and some empty arrays

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah the copyright must the default for the project, I'm guessing you were the one who initially created it. I'll add the empty stuff like you suggested for both Capacitor and Cordova across both this pr and the 5.x pr.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like I missed the link
https://github.com/apache/cordova-ios/blob/master/CordovaLib/PrivacyInfo.xcprivacy

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries I found it pretty easy

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made the same update for the 5.x PR #7315

@Steven0351 Steven0351 requested a review from jcesarmobile March 6, 2024 17:51
@Steven0351 Steven0351 mentioned this pull request Mar 7, 2024
Merged
@Steven0351
Copy link
Contributor Author

Closing in favor of #7321 that follows new branch naming rules.

@Steven0351 Steven0351 closed this Mar 7, 2024
@Steven0351 Steven0351 deleted the xcprivacy branch March 7, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giralte-ionic giralte-ionic giralte-ionic approved these changes

@jcesarmobile jcesarmobile jcesarmobile approved these changes

@markemer markemer markemer approved these changes

@theproducer theproducer Awaiting requested review from theproducer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Steven0351 @markemer @jcesarmobile @giralte-ionic