fix #133 - nil reference to CDV_LOCAL_SERVER #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @matejkramny Thanks so much man life saver |
|
Thanks @matejkramny, tested and works perfectly! |
src/ios/CDVWKWebViewEngine.m
Outdated
| @@ -755,10 +764,11 @@ -(void)setServerPath:(NSString *) path | |||
| if (restart) { | |||
| [self.webServer stop]; | |||
| } | |||
| NSString *serverUrl = self.CDV_LOCAL_SERVER; | |||
|
|
|||
| __block NSString* basePath = self.CDV_LOCAL_SERVER; | |||
There was a problem hiding this comment.
Don't rename to basePath as we have the self.basePath and can be confusing
jcesarmobile
requested changes
Aug 13, 2018
|
@jcesarmobile updated the variable. Thanks! |
|
Thanks! merged |
|
Thank you @matejkramny! Great work 💪 |
|
2.0.3 is published with this fix |
barnslig
pushed a commit
to barnslig/cordova-plugin-ionic-webview
that referenced
this pull request
Aug 30, 2018
* fix nil reference to CDV_LOCAL_SERVER fixes ionic-team#133 * remove empty spaces * remove more empty spaces * rename local basePath variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue is
self.CDV_LOCAL_SERVERis set when server is started, not when the_file_route is set up.The change sets up the
CDV_LOCAL_SERVERpath before both so that it's safely accessible in the file handler.