Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal connections only #186

Merged
merged 5 commits into from
Oct 4, 2018

Conversation

jcesarmobile
Copy link
Member

This will append the random string to the User Agent and will only allow connections based on the User Agent containing that random string.

Bumped version to 2.2.0 as it's a big enough change, and also other already merged changes like the kit-kat support

@imhoffd
Copy link
Contributor

imhoffd commented Oct 3, 2018

@jcesarmobile You don't need to bump the version. It's done automatically during publish (along with git tagging, github release creation, etc).

@imhoffd
Copy link
Contributor

imhoffd commented Oct 3, 2018

@jcesarmobile Not finding WKBind, WKSuspendInBackground, or WKInternalConnectionsOnly in the Android code. Are they supported in Android? If not, we should make note of that.

@mlynch
Copy link
Contributor

mlynch commented Oct 3, 2018

Looks good to me once we get some testing feedback from Brian and Matt re: deploy

@jcesarmobile
Copy link
Member Author

jcesarmobile commented Oct 3, 2018

@dwieeb yeah, those are iOS only, we can probably add WKBind, but the other two are not needed. Will edit the docs for now to specify that they are iOS only.

I bumped the version because Max bumped it to 2.1.5 in his branch and referred to that version in the readme, so I updated the readme to 2.2.0 and then bumped the version to avoid inconsistencies, but I can remove the bump if that will cause problems with the release script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants