Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(iOS): Issues related to keyboard dismissal (2.x) #532

Open
wants to merge 2 commits into
base: 2.x
Choose a base branch
from

Commits on Mar 23, 2020

  1. fix(iOS): Fix scroll issues related to keyboard dismissal (ionic-team…

    …#176) (ionic-team#399)
    
    - We only need the KeyboardWillHide event to fix this problem, and we only need it for ios 11+
    - Enable the fix for ios 11+, not only ios 12+. It was probably only 12+ because no devices have a max OS of 11, so no dev probably confirmed the problem's existence (or non-existence) on 11, myself included.  (But the functionality that started this issue chain began in ios 11.)
    - Do some math to make sure the offset when the keyboard goes down doesn't result in empty white space being displayed.
    - This solution can potentially be removed when apple finally releases the fix for the issue discussed here: apache/cordova-ios#417 (comment)
    For full details see PR ionic-team#532
    Lindsay-Needs-Sleep committed Mar 23, 2020
    Configuration menu
    Copy the full SHA
    d82b0f3 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2020

  1. Configuration menu
    Copy the full SHA
    e1a7e37 View commit details
    Browse the repository at this point in the history