Code changes are not reflected after a live reload - ionic serve

[comfortme]

Short description of the problem:

with ionic serve and chrome as browser, after saving the changes, live reload is triggered, code rebuilds, browser reloads but the changes are not reflected. i see the previous build. Have to save twice to make the changes updated in browser.
this problem does not happen every time though.
i dont know what causes this but it happens 1/3 of my saves.

What behavior are you expecting?

When saving the changes should be reflected.

Steps to reproduce:

1. Run ionic serve then open chrome for localhost:8100
2. Edit some file in the project and save
3. If you see the changes be patient and go back to step 2

**Which @ionic/app-scripts version are you using?**
app-scripts version: 0.0.42
Cordova CLI: 6.1.1
Ionic CLI Version: 2.1.7
Ionic App Lib Version: 2.1.4
ios-deploy version: Not installed
ios-sim version: Not installed
OS: Windows 7
Node Version: v6.7.0
Xcode version: Not installed

[danbucholtz]

@comfortme,

When you see this happen, can you manually reload the page and verify if the expected code is there or not. Maybe this is a race condition with watches since sometimes watches fire before the file is fully written. Hmmmm.

I cannot recreate this on Windows 7.

Thanks,
Dan

[comfortme]

this happens in my home computer too which is windows 8.1
i am using vscode as an editor maybe related to that? i'll check and inform you. thanks.

[comfortme]

@danbucholtz ,
i can verify that expected code is there.
i recreated the issue and reloaded page like you asked and the changes are reflected as expected.
tried it with notepad++ too still the same issue.

[danbucholtz]

Thanks for validating. It sounds like a race condition, we'll investigate.

Thanks,
Dan

[comfortme]

thank you,

weird notes from my observations,

---

1.change js file
2.live reload
3.view is not changed
4.reload manually
5.view is changed.

---

1.change html
2.live reload
3.view is changed

---

1.change js file
2.live reload
3.view is not changed
4.do not reload manually and change html now
5.live reload
6.view is changed but just html part.
7.reload manually
8.view is changed but just html part. js change is not reflected and code is not there anymore manually reloading does not work. you have to make another change in js.

[joshgarwood]

FWIW I'm seeing the same behavior as @comfortme

[danbucholtz]

Okay, there is definitely something wrong, then. We'll figure it out and fix it. Windows 10, right? I have never seen that behavior on Mac OS or Windows 7/8.

Thanks,
Dan

[webprofusion-chrisc]

Confirm that I see this on Windows 10, not sure if it happens every time but changing the JS sometimes needs another save for the change to be reflected, build output looks like this:

[13:35:19] build started ...
[13:35:19] transpile started ...
[13:35:23] transpile finished in 3.47 s
[13:35:23] webpack update started ...
[13:35:27] webpack update finished in 4.05 s
[13:35:27] build finished in 7.53 s

Bonus bug, the C in Cordova is missing when running 'ionic info'):

Your system information :

ordova CLI: 6.3.0
Ionic Framework Version: 2.0.0-rc.2
Ionic CLI Version: 2.1.7
Ionic App Lib Version: 2.1.4
Ionic App Scripts Version: 0.0.43
ios-deploy version: Not installed
ios-sim version: Not installed
OS: Windows 10
Node Version: v6.9.1
Xcode version: Not installed

[joshgarwood]

Yes, I'm on Windows 10 as well.

[danbucholtz]

@joshgarwood, @webprofusion-chrisc,

Any idea what's causing this? I cannot recreate on Windows 10 or windows 7. Both are VMs - not sure if that would have any impact.

Any idea how I can recreate this? Is there anything unique about your set-up? Do you have SSDs? I am noticing the build times seem a little slow - wondering if the file watch isn't triggering at the correct time or something. I'm not sure.

Please let me know if you have any ideas.

Thanks,
Dan

[joshgarwood]

Hey @danbucholtz .. Unfortunately I have no idea, ha. I can say that it happens most typically if I try to save multiple times in succession. So if I have 3 unsaved changes across 3 different files, and do Save All it seems to get confused. Also seems to happen randomly if I have an error in one of my templates (like calling a function that doesnt exist in my component).

It's still random overall, but your best chance at duping it (from my experience) is to make multiple saves in close succession.

Thanks again for looking into this; it'll definitely save me some pain and frustration once it's fixed, ha.

[arielfaur]

I am experiencing that same issue on Windows 10 with an SSD. I noticed that build times tend to get worse over time after a few builds. I am use Visual Studio Code.

 ordova CLI: 6.4.0
Ionic Framework Version: 2.0.0-rc.2
Ionic CLI Version: 2.1.8
Ionic App Lib Version: 2.1.4
Ionic App Scripts Version: 0.0.43
ios-deploy version: Not installed
ios-sim version: Not installed
OS: Windows 10
Node Version: v6.9.1
Xcode version: Not installed