Skip to content
This repository was archived by the owner on May 1, 2020. It is now read-only.

switched order of js & ts extensions in webpack.config #1058

Closed
wants to merge 1 commit into from
Closed

switched order of js & ts extensions in webpack.config #1058

wants to merge 1 commit into from

Conversation

edzillion
Copy link

Short description of what this resolves:

I was having an issue with angular2-notifications and it was suggested to switch the order of extensions in the webpack.config.js file:

flauc/angular2-notifications#134

Changes proposed in this pull request:

Switching the order of extensions in the config.webpack.js file.

File: node_modules\@ionic\app-scripts\config\webpack.config.js
15:   resolve: {
16:     extensions: ['.js', '.ts', '.json'],
17:     modules: [path.resolve('node_modules')]
18:   },

I am not sure what the knock on effects this would have, but it fixed the notification issue and didn't give any other errors on ionic cordova run android --prod

@danbucholtz
Copy link
Contributor

danbucholtz commented Oct 10, 2017

Hi @edzillion,

I have some concerns about doing this and I'm not convinced it is the right thing to do. At this time we don't plan on merging this, but we're open to continuing dialogue on the topic.

Thank you for the PR and contributing to Ionic.

Thanks,
Dan

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants