Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore!: bump required node version to 16 #4972

Merged
merged 3 commits into from
Mar 22, 2023
Merged

chore!: bump required node version to 16 #4972

merged 3 commits into from
Mar 22, 2023

Conversation

jcesarmobile
Copy link
Member

No description provided.

liamdebeasi
liamdebeasi approved these changes Mar 22, 2023
View reviewed changes
Copy link
Contributor

@liamdebeasi liamdebeasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two whitespace fixes, but otherwise this looks good.

packages/@ionic/utils-subprocess/src/index.ts Outdated Show resolved Hide resolved
packages/@ionic/discover/src/publisher.ts Outdated Show resolved Hide resolved
jcesarmobile and others added 2 commits March 22, 2023 19:09
@jcesarmobile @liamdebeasi
Update packages/@ionic/utils-subprocess/src/index.ts
ea9a29a 
Co-authored-by: Liam DeBeasi <liamdebeasi@users.noreply.github.com>
@jcesarmobile @liamdebeasi
Update packages/@ionic/discover/src/publisher.ts
a5c0d1b 
Co-authored-by: Liam DeBeasi <liamdebeasi@users.noreply.github.com>
@jcesarmobile
Copy link
Member Author

I would have expected npm run lint:fix to fix those, but npm run lint just returns true, so it does nothing.
good catch!

@jcesarmobile jcesarmobile merged commit 85fb4fa into next Mar 22, 2023
@jcesarmobile jcesarmobile deleted the node-16 branch March 22, 2023 18:21
liamdebeasi added a commit that referenced this pull request Mar 29, 2023
@jcesarmobile @liamdebeasi
chore!: bump required node version to 16 (#4972)
d3c4c48 

Co-authored-by: Liam DeBeasi <liamdebeasi@users.noreply.github.com>
liamdebeasi added a commit that referenced this pull request Mar 29, 2023
@jcesarmobile @liamdebeasi
chore!: bump required node version to 16 (#4972)
6493cc4 

Co-authored-by: Liam DeBeasi <liamdebeasi@users.noreply.github.com>
@sean-perkins sean-perkins mentioned this pull request Mar 31, 2023
Closed
@jonz94 jonz94 mentioned this pull request Apr 5, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liamdebeasi liamdebeasi liamdebeasi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jcesarmobile @liamdebeasi