Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(animations/grouped-animations): add React and Angular examples #1694

Closed
wants to merge 1 commit into from
Closed

docs(animations/grouped-animations): add React and Angular examples #1694

wants to merge 1 commit into from

Conversation

dillionmegida
Copy link
Contributor

@dillionmegida dillionmegida commented Oct 5, 2020

@liamdebeasi
Copy link
Contributor

Thank you for the PR, and apologies for the delay! We appreciate you contributing to Ionic. Since this PR was opened we have added "playgrounds" to our docs which provide interactive demos of code, per-JS Framework code snippets, and a link to open the code snippets in StackBlitz. As a result, I have opened #3025 to create a playground for the "Groups Animations" demo.

Preview URL: https://ionic-docs-git-grouped-anim-ionic1.vercel.app/docs/utilities/animations#grouped-animations

I am going to close this in favor of the linked PR, but I will give you co-author credit when this PR merges. Let me know if you have any questions.

@dillionmegida
Copy link
Contributor Author

Thank you so much Liam, for getting back to me. I have sincerely forgotten that I had this PR open 😂

And thanks for the co-author credit. Means a lot that my contribution is recognized. Also interesting to see that changes from 3 years ago, are still valid today, with the many moving parts in technologies nowadays.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants