Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin the versions for angular to v5 #2804

Closed
wants to merge 1 commit into from
Closed

Conversation

skofgar
Copy link
Contributor

@skofgar skofgar commented Mar 2, 2023

setting @ionic/angular@5 and @ionic/angular-toolkit@5 is important, otherwise this will skip the migration to v5 and go straight to v6 or any other, newer packages.

setting `@ionic/angular@5` and `@ionic/angular-toolkit@5` is important, otherwise this will skip the migration to v5 and go straight to v6 or any other, newer packages.
@vercel
Copy link

vercel bot commented Mar 2, 2023

@skofgar is attempting to deploy a commit to the Ionic Team on Vercel.

A member of the Team first needs to authorize it.

@averyjohnston
Copy link
Contributor

Thank you for the PR! There are a few other places where the npm install commands needed updating, but I noticed that the migration guides hosted on the v7 version of the docs have properly pinned versions (example). So, I created #2871 to edit the versioned pages to link to these latest versions instead, side-stepping the issue and narrowing things to one source of truth.

I'm going to close this PR in lieu of the aforementioned one, but I've given you co-author credit when merging. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants