Skip to content

docs(slides): update React and Vue migration guides to be compatible with Swiper 9 #2819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 13, 2023

Conversation

averyjohnston
Copy link
Contributor

@averyjohnston averyjohnston commented Mar 10, 2023

Because we decided to stick with Swiper's React/Vue components instead of Swiper Element for now, updating the guides for these two frameworks is mostly minor cleanup things. I also took the liberty of fixing some typos and adjusting the React docs to use the React-formatted component name.

Angular will be handled in a separate PR, as it will be a more significant overhaul to use Swiper Element instead. Updating the example repo linked at the bottom of the docs will also be done later. These changes should all be merged at the same time.

@vercel
Copy link

vercel bot commented Mar 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
ionic-docs ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 13, 2023 at 8:36PM (UTC)

@averyjohnston averyjohnston changed the title docs(slides): update React and Vue docs to be compatible with Swiper 9 docs(slides): update React and Vue migration guides to be compatible with Swiper 9 Mar 10, 2023
@averyjohnston averyjohnston requested a review from a team March 13, 2023 18:07
@averyjohnston averyjohnston marked this pull request as ready for review March 13, 2023 18:07
Copy link
Contributor

@liamdebeasi liamdebeasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

edit: Sorry, saw custom elements copy right after I hit submit 😭

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants