-
Notifications
You must be signed in to change notification settings - Fork 3.1k
docs(slides): update React and Vue migration guides to be compatible with Swiper 9 #2819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
liamdebeasi
reviewed
Mar 13, 2023
liamdebeasi
approved these changes
Mar 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
edit: Sorry, saw custom elements copy right after I hit submit 😭
liamdebeasi
reviewed
Mar 13, 2023
This was referenced Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because we decided to stick with Swiper's React/Vue components instead of Swiper Element for now, updating the guides for these two frameworks is mostly minor cleanup things. I also took the liberty of fixing some typos and adjusting the React docs to use the React-formatted component name.
Angular will be handled in a separate PR, as it will be a more significant overhaul to use Swiper Element instead. Updating the example repo linked at the bottom of the docs will also be done later. These changes should all be merged at the same time.