Skip to content

docs(input, textarea): fix specificity issues with theming playgrounds #3199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 17, 2023
Merged

docs(input, textarea): fix specificity issues with theming playgrounds #3199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
cda5db3
docs(textarea): fix specificity theming issue
liamdebeasi Oct 17, 2023
a1ab732
docs(input): fix specificity issue with theming
liamdebeasi Oct 17, 2023
3c0f12a
lint
liamdebeasi Oct 17, 2023
8a1f2d0
more lint
liamdebeasi Oct 17, 2023
bba2102
Update static/usage/v7/input/theming/css-properties/angular/global_cs…
liamdebeasi Oct 17, 2023
b555e31
use different color to make it clear the text is customized
liamdebeasi Oct 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions static/usage/v7/input/theming/css-properties/angular/example_component_css.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,4 @@ ion-input.custom {
--padding-start: 10px;
--padding-top: 10px;
}

ion-input.custom .helper-text,
ion-input.custom .counter {
color: var(--ion-color-step-700, #373737);
}
```
14 changes: 14 additions & 0 deletions static/usage/v7/input/theming/css-properties/angular/global_css.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
```css
/**
* Since we are styling elements inside of ion-input
* we need to move this CSS to a global stylesheet. Otherwise,
* Angular components with encapsulation enabled will add
* scoped style attributes to these selectors.
*/
ion-input.custom.ios .input-bottom .helper-text,
ion-input.custom.ios .input-bottom .counter,
ion-input.custom.md .input-bottom .helper-text,
ion-input.custom.md .input-bottom .counter {
color: var(--ion-color-primary);
}
```
8 changes: 5 additions & 3 deletions static/usage/v7/input/theming/css-properties/demo.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,11 @@
--padding-top: 10px;
}

ion-input.custom .helper-text,
ion-input.custom .counter {
color: var(--ion-color-step-700, #373737);
ion-input.custom.ios .input-bottom .helper-text,
ion-input.custom.ios .input-bottom .counter,
ion-input.custom.md .input-bottom .helper-text,
ion-input.custom.md .input-bottom .counter {
color: var(--ion-color-primary);
}
</style>
</head>
Expand Down
2 changes: 2 additions & 0 deletions static/usage/v7/input/theming/css-properties/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import vue from './vue.md';

import angular_example_component_html from './angular/example_component_html.md';
import angular_example_component_css from './angular/example_component_css.md';
import angular_global_css from './angular/global_css.md';

<Playground
version="7"
Expand All @@ -25,6 +26,7 @@ import angular_example_component_css from './angular/example_component_css.md';
files: {
'src/app/example.component.html': angular_example_component_html,
'src/app/example.component.css': angular_example_component_css,
'src/global.css': angular_global_css,
},
},
}}
Expand Down
8 changes: 5 additions & 3 deletions static/usage/v7/input/theming/css-properties/javascript.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,11 @@
--padding-top: 10px;
}

ion-input.custom .helper-text,
ion-input.custom .counter {
color: var(--ion-color-step-700, #373737);
ion-input.custom.ios .input-bottom .helper-text,
ion-input.custom.ios .input-bottom .counter,
ion-input.custom.md .input-bottom .helper-text,
ion-input.custom.md .input-bottom .counter {
color: var(--ion-color-primary);
}
</style>
```
8 changes: 5 additions & 3 deletions static/usage/v7/input/theming/css-properties/react/main_css.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,10 @@ ion-input.custom {
--padding-top: 10px;
}

ion-input.custom .helper-text,
ion-input.custom .counter {
color: #373737;
ion-input.custom.ios .input-bottom .helper-text,
ion-input.custom.ios .input-bottom .counter,
ion-input.custom.md .input-bottom .helper-text,
ion-input.custom.md .input-bottom .counter {
color: var(--ion-color-primary);
}
```
8 changes: 5 additions & 3 deletions static/usage/v7/input/theming/css-properties/vue.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,11 @@
--padding-top: 10px;
}

ion-input.custom .helper-text,
ion-input.custom .counter {
color: var(--ion-color-step-700, #373737);
ion-input.custom.ios .input-bottom .helper-text,
ion-input.custom.ios .input-bottom .counter,
ion-input.custom.md .input-bottom .helper-text,
ion-input.custom.md .input-bottom .counter {
color: var(--ion-color-primary);
}
</style>
```
5 changes: 0 additions & 5 deletions static/usage/v7/textarea/theming/angular/example_component_css.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,4 @@ ion-textarea.custom {
--placeholder-color: #ddd;
--placeholder-opacity: 0.8;
}

ion-textarea.custom .helper-text,
ion-textarea.custom .counter {
color: #373737;
}
```
14 changes: 14 additions & 0 deletions static/usage/v7/textarea/theming/angular/global_css.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
```css
/**
* Since we are styling elements inside of ion-textarea
* we need to move this CSS to a global stylesheet. Otherwise,
* Angular components with encapsulation enabled will add
* scoped style attributes to these selectors.
*/
ion-textarea.custom.ios .textarea-bottom .helper-text,
ion-textarea.custom.ios .textarea-bottom .counter,
ion-textarea.custom.md .textarea-bottom .helper-text,
ion-textarea.custom.md .textarea-bottom .counter {
color: var(--ion-color-primary);
}
```
8 changes: 5 additions & 3 deletions static/usage/v7/textarea/theming/demo.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,11 @@
--placeholder-opacity: 0.8;
}

ion-textarea.custom .helper-text,
ion-textarea.custom .counter {
color: #373737;
ion-textarea.custom.ios .textarea-bottom .helper-text,
ion-textarea.custom.ios .textarea-bottom .counter,
ion-textarea.custom.md .textarea-bottom .helper-text,
ion-textarea.custom.md .textarea-bottom .counter {
color: var(--ion-color-primary);
}
</style>
</head>
Expand Down
2 changes: 2 additions & 0 deletions static/usage/v7/textarea/theming/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import vue from './vue.md';

import angular_example_component_html from './angular/example_component_html.md';
import angular_example_component_css from './angular/example_component_css.md';
import angular_global_css from './angular/global_css.md';

<Playground
version="7"
Expand All @@ -26,6 +27,7 @@ import angular_example_component_css from './angular/example_component_css.md';
files: {
'src/app/example.component.css': angular_example_component_css,
'src/app/example.component.html': angular_example_component_html,
'src/global.css': angular_global_css,
},
},
}}
Expand Down
8 changes: 5 additions & 3 deletions static/usage/v7/textarea/theming/javascript.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,11 @@
--placeholder-opacity: 0.8;
}

ion-textarea.custom .helper-text,
ion-textarea.custom .counter {
color: #373737;
ion-textarea.custom.ios .textarea-bottom .helper-text,
ion-textarea.custom.ios .textarea-bottom .counter,
ion-textarea.custom.md .textarea-bottom .helper-text,
ion-textarea.custom.md .textarea-bottom .counter {
color: var(--ion-color-primary);
}
</style>
```
8 changes: 5 additions & 3 deletions static/usage/v7/textarea/theming/react/main_css.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,10 @@ ion-textarea.custom {
--placeholder-opacity: 0.8;
}

ion-textarea.custom .helper-text,
ion-textarea.custom .counter {
color: #373737;
ion-textarea.custom.ios .textarea-bottom .helper-text,
ion-textarea.custom.ios .textarea-bottom .counter,
ion-textarea.custom.md .textarea-bottom .helper-text,
ion-textarea.custom.md .textarea-bottom .counter {
color: var(--ion-color-primary);
}
```
8 changes: 5 additions & 3 deletions static/usage/v7/textarea/theming/vue.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,11 @@
--placeholder-opacity: 0.8;
}

ion-textarea.custom .helper-text,
ion-textarea.custom .counter {
color: #373737;
ion-textarea.custom.ios .textarea-bottom .helper-text,
ion-textarea.custom.ios .textarea-bottom .counter,
ion-textarea.custom.md .textarea-bottom .helper-text,
ion-textarea.custom.md .textarea-bottom .counter {
color: var(--ion-color-primary);
}
</style>

Expand Down