Skip to content

Conversation

rdlabo
Copy link
Collaborator

@rdlabo rdlabo commented Feb 11, 2024

It took a little while, but I followed up the main branch.

liamdebeasi and others added 30 commits October 4, 2023 13:41
* chore: resolve cspell errors

* chore: ignore all node_modules folders

* chore: adjust sorting
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
# Conflicts:
#	docs/angular/testing.md
#	docs/api/checkbox.md
#	docs/api/datetime.md
#	docs/api/fab.md
#	docs/api/input.md
#	docs/api/item.md
#	docs/api/modal.md
#	docs/api/radio.md
#	docs/api/select.md
#	docs/api/toggle.md
#	docs/components.md
#	docs/core-concepts/what-are-progressive-web-apps.md
#	docs/react/navigation.md
#	docs/react/pwa.md
#	docs/theming/advanced.md
#	docs/vue/overview.md
#	docs/vue/quickstart.md
#	package-lock.json
#	package.json
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
chore: release ionic 7.5 docs
@rdlabo rdlabo requested a review from a team as a code owner February 11, 2024 03:04
@rdlabo rdlabo requested review from liamdebeasi and removed request for a team February 11, 2024 03:04
Copy link

vercel bot commented Feb 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 12, 2024 3:56am

@@ -0,0 +1,236 @@
// const fetch = require('node-fetch');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove this file if we don't need it?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it can now be deleted. It can also be removed from the current build script.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I should have asked this originally, but can you clarify why we don't need this script anymore? In main it looks like we still use it:

node scripts/api-ja.js

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, remove from main branch will not effect. Files no longer in use now.

However, this issue needs to be discussed: #3096

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification!

@liamdebeasi
Copy link
Contributor

Thanks for getting this up to date!

Copy link
Contributor

@liamdebeasi liamdebeasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@rdlabo rdlabo merged commit a4b02e7 into translation/jp Feb 28, 2024
@rdlabo rdlabo deleted the translation/jp-20240211 branch February 28, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.