Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(app): add demo for the setFocus method #3842

Merged
merged 2 commits into from
Oct 1, 2024
Merged

docs(app): add demo for the setFocus method #3842

merged 2 commits into from
Oct 1, 2024

Conversation

brandyscarney
Copy link
Member

@brandyscarney brandyscarney commented Sep 30, 2024

Adds documentation and a demo for how to use the setFocus method with ion-app to programmatically focus Ionic components.

Related issue: ionic-team/ionic-framework#29830

Preview: https://ionic-docs-git-rou-11157-ionic1.vercel.app/docs/api/app#programmatic-focus

Copy link

vercel bot commented Sep 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 1, 2024 2:14pm

Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/api/app.md Outdated Show resolved Hide resolved
Copy link
Member

@tanner-reits tanner-reits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@brandyscarney brandyscarney merged commit 0fccd65 into main Oct 1, 2024
4 checks passed
@brandyscarney brandyscarney deleted the ROU-11157 branch October 1, 2024 18:23
github-merge-queue bot pushed a commit to ionic-team/ionic-framework that referenced this pull request Oct 1, 2024
Issue number: resolves #29830

---------

## What is the current behavior?
The `setFocus` method on `ion-app` is marked internal.

## What is the new behavior?
Document the `setFocus` method as a way for developers to
programmatically focus elements.

## Does this introduce a breaking change?

- [ ] Yes
- [x] No

## Other information

The method isn’t new, it was just marked as internal, which prevented it
from being documented. I can mark this as a `feat` though if anyone
thinks it should be.

Related documentation PR:
ionic-team/ionic-docs#3842
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants