Skip to content

Commit

Permalink
fix(vue): account for event name changes in vue 3.0.6+ (#22980)
Browse files Browse the repository at this point in the history
resolves #22977
  • Loading branch information
liamdebeasi committed Feb 26, 2021
1 parent 7b160e6 commit 594be7d
Show file tree
Hide file tree
Showing 8 changed files with 213 additions and 127 deletions.
21 changes: 7 additions & 14 deletions core/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion core/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
"@rollup/plugin-virtual": "^2.0.3",
"@stencil/core": "2.1.2",
"@stencil/sass": "1.3.2",
"@stencil/vue-output-target": "0.3.0",
"@stencil/vue-output-target": "^0.4.1",
"@types/jest": "^26.0.10",
"@types/node": "^14.6.0",
"@types/puppeteer": "3.0.1",
Expand Down
6 changes: 4 additions & 2 deletions core/stencil.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -91,13 +91,15 @@ export const config: Config = {
{
elements: ['ion-checkbox', 'ion-toggle'],
targetAttr: 'checked',
event: 'v-ionChange',
// TODO Ionic v6 remove in favor of v-ion-change
event: ['v-ionChange', 'v-ion-change'],
externalEvent: 'ionChange'
},
{
elements: ['ion-datetime', 'ion-input', 'ion-radio-group', 'ion-radio', 'ion-range', 'ion-searchbar', 'ion-segment', 'ion-segment-button', 'ion-select', 'ion-textarea'],
targetAttr: 'value',
event: 'v-ionChange',
// TODO Ionic v6 remove in favor of v-ion-change
event: ['v-ionChange', 'v-ion-change'],
externalEvent: 'ionChange'
}
],
Expand Down
Loading

0 comments on commit 594be7d

Please sign in to comment.