fix(overlay): onWillDismiss is called as expected (#12056)

* fix(overlay): onWillDismiss is called as expected

fixes #11702

* Fix condition

src/navigation/nav-controller-base.ts

@@ -806,7 +806,10 @@ export class NavControllerBase extends Ion implements NavController {
     if (enteringView || leavingView) {
       this._zone.run(() => {
         // Here, the order is important. WillLeave must be called before WillEnter.
-        leavingView && this._willLeave(leavingView, !enteringView);
+        if (leavingView) {
+          const willUnload = enteringView ? leavingView.index > enteringView.index : true;
+          this._willLeave(leavingView, willUnload);
+        }
         enteringView && this._willEnter(enteringView);
       });
     }
@@ -858,9 +861,12 @@ export class NavControllerBase extends Ion implements NavController {
   _cleanup(activeView: ViewController) {
     // ok, cleanup time!! Destroy all of the views that are
     // INACTIVE and come after the active view
+
     // only do this if the views exist, though
     if (!this._destroyed) {
       const activeViewIndex = this._views.indexOf(activeView);
+      assert(activeViewIndex >= 0, 'active index is invalid');
+
       const views = this._views;
       let reorderZIndexes = false;
       let view: ViewController;
@@ -1121,7 +1127,8 @@ export class NavControllerBase extends Ion implements NavController {
       view = this.getActive();
     }
     const views = this._views;
-    return views[views.indexOf(view) - 1];
+    const index = views.indexOf(view);
+    return (index > 0) ? views[index - 1] : null;
   }
 
   first(): ViewController {
@@ -1131,7 +1138,8 @@ export class NavControllerBase extends Ion implements NavController {
 
   last(): ViewController {
     // returns the last page in this nav controller's stack.
-    return this._views[this._views.length - 1];
+    const views = this._views;
+    return views[views.length - 1];
   }
 
   indexOf(view: ViewController): number {
@@ -1143,9 +1151,6 @@ export class NavControllerBase extends Ion implements NavController {
     return this._views.length;
   }
 
-  /**
-   * Return the stack of views in this NavController.
-   */
   getViews(): Array<ViewController> {
     return this._views;
   }

src/navigation/nav-controller.ts

@@ -581,7 +581,6 @@ export abstract class NavController implements NavigationContainer {
    */
   abstract length(): number;
 
-
   /**
    * Returns the current stack of views in this nav controller.
    * @returns {Array<ViewController>} the stack of view controllers in this nav controller.