-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Touchstart on input cancels ion-content scrolling #1078
Comments
Yes this is a known issue which @tlancina and I are actively working on. A cross platform/browser solution isn't as simple as one would think. Once we iron out the keyboard and focus issues then touchstart scrolling when the target is the input is next our next priority. We're making sure to work on them separately because one drastically affects the other so need to get the keyboard/focus issues 100% first (heavily tested with both unit tests and on physical devices). |
@adamdbradley If you need any device testing on this issue, let me know. We have a Galaxy S4 (Android 4.3) Galaxy S3 Mini (Android 4.2.1) Galaxy S1 (Android 2.3.6) iPhone 4 (iOS 7.1) and iPhone 5 (iOS 7.1) all rigged with an Ionic app full of input's and other fancy stuff, ready to test. |
@rvanbaalen That'd be great thanks. I'll update this post when we get our updates in the nightly build. |
You're welcome. It's the least I can do since I really need that update before our app launches and that deadline is getting closer and closer. |
Notes:
|
The changes are in nightly, build 1609, or later. Would I be able to ask this group to test it out? A few notes:
Please let us know how the testing goes, thanks. |
Hi @adamdbradley, I was looking around for anything to do with inputs/touch/range and these were the closest changes I could find. I haven't updated to nightly since but at some point range sliders stopped working. Sorry if this is the wrong place to mention this. I was trying to see if I could find the problem myself to help out but got stuck. |
So far scrolling looks okay in the situations we use inputs. I'll update more info after we try on all of our test devices |
Testing time! Fixes have been put into master, and any help would be appreciated: Thanks |
Im on it! 👍 |
Me too! Thanks guys! |
Fixed on Galaxy S4 (android 4.3) and iPhone 4 (iOS7.1) Will be testing on Galaxy S3 Mini (4.1.2) and iPhone 5 (7.1) later. |
@adamdbradley Has this issue reappeared on iOS? I cant seem to scroll a page whenever I touch an input / span.input-label and drag up / down. <div class="list">
<label class="item item-input item-stacked-label item-borderless">
<span class="input-label">label<strong>extra</strong></span>
<div class="range">
<input type="range" min="1" max="100" value="1">
</div>
</label>
<label class="item item-input item-stacked-label item-borderless">
<span class="input-label">label</span>
<input type="text">
</label>
</div> The error occurs on the text input. Does not occur on the range input. |
Yes, seems I have the problem too on ios |
Slight twist on this issue I think is using a range input in a modal the input doesn't get the events at all under ios9. I've tried turning off scroll on the ion-content but still no joy. Works in the browser but not on the simulator or device. |
@adamdbradley reopen perhaps? |
Apparently I can't reopen this issue because I didn't raise it. Perhaps I'll raise a new issue and link to this one if I can. |
Yes @bownie - cannot find why it's not working... keep searching. If someone can reopen |
@gary149 |
Simply remove overflow-scroll="true" from ion-content, and you'll be well on your way! |
w iOS jebie się scroll na komponentach formularzy ionic - fix zgodnie z ionic-team/ionic-framework#1078
@briankasingli @adamdbradley What if for some reason I need to use overflow-scroll="true" ...is there any workaround to make form inputs not receiving events while scrolling? (problem is only in iOS, android works fine) |
@tomkaba after spending 60 hours on this problem, I found a work around that enables you to scroll (ion-content, over-scroll="true") when the input field is focused (selected). Essentially, the reason why you cant scroll when the input field is focused is because the input field, and targeted container that you want to scroll in lives within another "ion-content". The first "ion-content" will create some special classes which restricts you from scrolling content when your focused in the input field. My code looks something like this =>
My Solution:
This solution worked for me, let me know if it worked for you. |
@adamdbradley This is an issue again, but only on iOS and only with native scrolling enabled. It should be reopened. Update: It seems it's only an issue when there is a label tag wrapped around the input. I'm creating a new issue for this. Update: new issue at #5102 |
Just been tearing my hair out trying to fix this issue. I can confirm what @Manduro says; it only blocks scrolling with a label wrapper, not a div wrapper. This change fixed it for me - hopefully it will for someone else too! Thank you. |
@Manduro I tried replacing labels with divs, but that didn't do the trick on iOS for me. It's probably since I was embedding the labels / inputs in a popup rather than just in ion-content. replacing the inputs with textareas worked though. Must be something weird going on with the inputs and touch events |
+1 |
+1 |
Hello I am using ionic@1.7.14 and cordova@6.1.1. I am seeing this same issue. I need the overflow-scroll="true" in order to make the form look OK, however now the user cannot scroll on the input elements and that looks terrible again. does anyone have a good workaround?
|
@philipbrack did you try my solution? |
is this fixed? I am tired of ionic and iOS quirks. sure ionic is a great framework but it have big issues that needs to be addressed especially on ios like scroll, blank screen on input focus, blur.etc. |
+1 |
2 similar comments
+1 |
+1 |
+1 @briankasingli nice answer, exactly what i was looking for, my app was a mess, thank you man |
@elijax thats great news! |
+1 still relevant! Using divs instead of labels, and removing overflow scroll fixed the issue for me on ios. |
Replace
|
Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out. |
If you have an ion-content element with a tonne of inputs, you cant scroll down because the inputs receive the event and focuses immediately. This happens in chrome, iOS 7.1 and on a nexus 5
Have tried using ion-scroll, ion-content with
overflow-scroll='true'
, with and without labels, nothing seems to work.Is there a convention here that i don't know about? It seems like a massive game breaker for anyone who wants to use inputs
Latest nightly tested
The text was updated successfully, but these errors were encountered: