Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow platform grade to be set by developer #1104

Closed
bostondv opened this issue Apr 10, 2014 · 5 comments
Closed

allow platform grade to be set by developer #1104

bostondv opened this issue Apr 10, 2014 · 5 comments

Comments

@bostondv
Copy link

This is probably a case not a lot of users will run in to, but I'm using Crosswalk and Cordova to make an Android app that runs the Chromium webview for all devices 4.0+.

Using Crosswalk, on a 4.3 Galaxy S4 the class is getting ".grade-b". Normally with the 4.3 webview this is correct, but with the app running a Chromium webview I think it should be given Grade-A status as it's essentially the same as 4.4's chrome webview.

https://crosswalk-project.org/

@ajoslin
Copy link
Contributor

ajoslin commented Apr 11, 2014

We should probably add a ionicPlatform.setGrade function, so you can override this.

In the interim, you can manually edit the body's class. document.body.classList.remove('grade-b'); document.body.classList.add('grade-a');

@ajoslin ajoslin self-assigned this Apr 11, 2014
@bostondv
Copy link
Author

That’d work :)

@niiamon
Copy link

niiamon commented Apr 13, 2014

@bostondv care to share how you've setup your project? I have an existing project which I started with the Ionic CLI. I have downloaded and setup a project with Crosswalk and the folder structure looks very much like the normal Cordova android. I am curious to see how others are integrating Cordova, Ionic and Crosswalk.

@bostondv
Copy link
Author

@niiamon I used their cordova android project here to generate the android platform: https://github.com/crosswalk-project/crosswalk-cordova-android

The output was virtually identical to what Cordova CLI produces with the addition of the xwalk libs, so I was able to replace my existing /platforms/android dir with the xwalk build. The Cordova CLI so far at least has worked seamlessly with it to build, run, add plugins, etc.

@bostondv bostondv changed the title Crosswalk webview and grade rating allow platform grade to be set by developer May 2, 2014
@ionitron-bot
Copy link

ionitron-bot bot commented Sep 6, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants