-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow platform grade to be set by developer #1104
Comments
We should probably add a ionicPlatform.setGrade function, so you can override this. In the interim, you can manually edit the body's class. |
That’d work :) |
@bostondv care to share how you've setup your project? I have an existing project which I started with the Ionic CLI. I have downloaded and setup a project with Crosswalk and the folder structure looks very much like the normal Cordova android. I am curious to see how others are integrating Cordova, Ionic and Crosswalk. |
@niiamon I used their cordova android project here to generate the android platform: https://github.com/crosswalk-project/crosswalk-cordova-android The output was virtually identical to what Cordova CLI produces with the addition of the xwalk libs, so I was able to replace my existing /platforms/android dir with the xwalk build. The Cordova CLI so far at least has worked seamlessly with it to build, run, add plugins, etc. |
Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out. |
This is probably a case not a lot of users will run in to, but I'm using Crosswalk and Cordova to make an Android app that runs the Chromium webview for all devices 4.0+.
Using Crosswalk, on a 4.3 Galaxy S4 the class is getting ".grade-b". Normally with the 4.3 webview this is correct, but with the app running a Chromium webview I think it should be given Grade-A status as it's essentially the same as 4.4's chrome webview.
https://crosswalk-project.org/
The text was updated successfully, but these errors were encountered: