Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong border-bottom of the last <ion-input> inside a <ion-list> #13218

Closed
Ivan-Perez opened this issue Oct 23, 2017 · 8 comments
Closed

Wrong border-bottom of the last <ion-input> inside a <ion-list> #13218

Ivan-Perez opened this issue Oct 23, 2017 · 8 comments

Comments

@Ivan-Perez
Copy link
Contributor

Ionic version: (check one with "x")
(For Ionic 1.x issues, please use https://github.com/ionic-team/ionic-v1)
[ ] 2.x
[x] 3.x
[ ] 4.x

I'm submitting a ... (check one with "x")
[x] bug report
[ ] feature request

Current behavior:
The last input on a form inside a <ion-list> shows at longer boder-bottom than the previous ones in Android.

Expected behavior:
All of them should be the same.

Steps to reproduce:

Use this page template to reproduce the issue:

<ion-header>
  <ion-navbar>
    <ion-title>Form test</ion-title>
  </ion-navbar>
</ion-header>

<ion-content>
  <ion-list>
    <ion-item>
      <ion-label>First input</ion-label>
      <ion-input></ion-input>
    </ion-item>
    <ion-item>
      <ion-label>Another input</ion-label>
      <ion-input></ion-input>
    </ion-item>
    <ion-item>
      <ion-label>One more input</ion-label>
      <ion-input></ion-input>
    </ion-item>
  </ion-list>
</ion-content>

You get something like the image below (highlighted what I'm referring to):

ionic-style-issue

Related code:

https://stackblitz.com/edit/ionic-idg4tc - Check pages/home/home.html.

Ionic info: (run ionic info from a terminal/cmd prompt and paste output below):

cli packages: (C:\Users\Ivan.Perez\AppData\Roaming\npm\node_modules)

    @ionic/cli-utils  : 1.13.1
    ionic (Ionic CLI) : 3.13.2

global packages:

    cordova (Cordova CLI) : 7.0.1

local packages:

    @ionic/app-scripts : 1.3.12
    Cordova Platforms  : none
    Ionic Framework    : ionic-angular 3.5.0

System:

    Node : v6.11.0
    npm  : 3.10.10
    OS   : Windows 7

Misc:

    backend : legacy

@kensodemann
Copy link
Member

Hello! Thank you for opening an issue with us!

This may or may not be intentional. I have labeled this with the "design decision" label because these types of things are going to be reviewed again in the near future.

Thank you for using Ionic

@Batur24
Copy link

Batur24 commented Feb 5, 2018

it's a bit annoying, are there good methods for this?

@Beni90
Copy link

Beni90 commented Feb 8, 2018

Guys, is there any solution for this? This is quite annoying!

@v1bh0r
Copy link

v1bh0r commented Mar 10, 2018

The material design specs clearly are against the observed behavior here https://material.io/guidelines/components/text-fields.html
Following are some screenshot from the specs documentation:

image

image

Unless there's a clear reason why this design decision was made, we should make this change based on the Material Design specs.

Found the related PR - #9679

brandyscarney added a commit that referenced this issue May 7, 2018
…14407)

* docs(components): update grammar and docs

* docs(item): update item documentation and add usage

* test(item): add lines test

* feat(list): add lines property to override borders on items

* feat(item): add lines property to override borders on items

* refactor(item): remove old uses of no-lines attribute

* fix(item-sliding): update item options to show border

- show the border on left options only if in a full list
- show the border on both options only if in an inset list (or ios by
default)
- don’t show border on either for no lines list (and md by default)

also renames isRightSide to isEndSide to match the side values

* chore(package): update package lock

* style(item): fix lint errors

* test(item): update item tests

* refactor(item): remove the custom styling of last child items

instead of us overriding first/last child items to have borders we are
going to add to the documentation how to style items with a full border

* fix(item): apply border to item inputs for MD mode

* docs(components): update docs based on new build

* docs(usage): update item usage to show lines being used

* fix(item): do not set the padding right to 0 on an item by default

* fix(item): cast lines to boolean

fixes: #5537 #13218 #12689 #12073 #9112
@brandyscarney
Copy link
Member

Fixed by 427222c

@giovannipds
Copy link

Is there a way to quick fix this on an app using an Ionic older version?

@giovannipds
Copy link

Like this:

<ion-list>

  <ion-item>
    <ion-label floating>Email</ion-label>
    <ion-input required type="email"></ion-input>
  </ion-item>

  <ion-item>
    <ion-label floating>Password</ion-label>
    <ion-input required type="password"></ion-input>
  </ion-item>

  <div hidden></div>

</ion-list>

@ionitron-bot
Copy link

ionitron-bot bot commented Sep 1, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants