-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong border-bottom of the last <ion-input> inside a <ion-list> #13218
Comments
Hello! Thank you for opening an issue with us! This may or may not be intentional. I have labeled this with the "design decision" label because these types of things are going to be reviewed again in the near future. Thank you for using Ionic |
it's a bit annoying, are there good methods for this? |
Guys, is there any solution for this? This is quite annoying! |
The material design specs clearly are against the observed behavior here https://material.io/guidelines/components/text-fields.html Unless there's a clear reason why this design decision was made, we should make this change based on the Material Design specs. Found the related PR - #9679 |
…14407) * docs(components): update grammar and docs * docs(item): update item documentation and add usage * test(item): add lines test * feat(list): add lines property to override borders on items * feat(item): add lines property to override borders on items * refactor(item): remove old uses of no-lines attribute * fix(item-sliding): update item options to show border - show the border on left options only if in a full list - show the border on both options only if in an inset list (or ios by default) - don’t show border on either for no lines list (and md by default) also renames isRightSide to isEndSide to match the side values * chore(package): update package lock * style(item): fix lint errors * test(item): update item tests * refactor(item): remove the custom styling of last child items instead of us overriding first/last child items to have borders we are going to add to the documentation how to style items with a full border * fix(item): apply border to item inputs for MD mode * docs(components): update docs based on new build * docs(usage): update item usage to show lines being used * fix(item): do not set the padding right to 0 on an item by default * fix(item): cast lines to boolean fixes: #5537 #13218 #12689 #12073 #9112
Fixed by 427222c |
Is there a way to quick fix this on an app using an Ionic older version? |
Like this: <ion-list>
<ion-item>
<ion-label floating>Email</ion-label>
<ion-input required type="email"></ion-input>
</ion-item>
<ion-item>
<ion-label floating>Password</ion-label>
<ion-input required type="password"></ion-input>
</ion-item>
<div hidden></div>
</ion-list> |
Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out. |
Ionic version: (check one with "x")
(For Ionic 1.x issues, please use https://github.com/ionic-team/ionic-v1)
[ ] 2.x
[x] 3.x
[ ] 4.x
I'm submitting a ... (check one with "x")
[x] bug report
[ ] feature request
Current behavior:
The last input on a form inside a
<ion-list>
shows at longer boder-bottom than the previous ones in Android.Expected behavior:
All of them should be the same.
Steps to reproduce:
Use this page template to reproduce the issue:
You get something like the image below (highlighted what I'm referring to):
Related code:
https://stackblitz.com/edit/ionic-idg4tc - Check
pages/home/home.html
.Ionic info: (run
ionic info
from a terminal/cmd prompt and paste output below):The text was updated successfully, but these errors were encountered: