Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4 Color Issues #14196

Closed
5 tasks done
brandyscarney opened this issue Mar 19, 2018 · 1 comment
Closed
5 tasks done

v4 Color Issues #14196

brandyscarney opened this issue Mar 19, 2018 · 1 comment
Assignees

Comments

@brandyscarney
Copy link
Member

brandyscarney commented Mar 19, 2018

Ionic version: (check one with "x")
(For Ionic 1.x issues, please use https://github.com/ionic-team/ionic-v1)
[ ] 2.x
[ ] 3.x
[x] 4.x

I'm submitting a ... (check one with "x")
[x] bug report
[ ] feature request

After discussion with @bensperry, we need to make some color corrections. Snapshot comparison for reference: http://ionic-snapshot-go.appspot.com/ionic-core/snapshots/v3-master/ye9/chrome_400x800

Alert

  • MD text is lighter
  • MD input borders on prompt look darker

Chip

  • Chip default background is too dark

Searchbar

  • Input background color is too dark (alpha should be .07)

Split Pane

  • The border between menu and content for MD mode should have transparency (alpha should be .13):

screen_shot_2018-03-19_at_5_02_35_pm

It should be black (or super dark) but with opacity to get it close to the same color as the solid one in there now.

Here is the value that the item border color should use in order to show a transparent border that still shows up as #dedede

1px solid rgba(var(--ion-item-md-border-color-rgb, var(--ion-item-border-color-rgb, 0, 0, 0)), var(--ion-alpha-md-border-medium, var(--ion-alpha-border-medium, 0.13)))

We don't have an alpha variable with the value of 0.13 though, so these are the current options:

Variable Opacity Rendered Color
$alpha-border-low .1 #e5e5e5
$alpha-border-medium .2 #cccccc
@ionitron-bot ionitron-bot bot added the triage label Mar 19, 2018
@brandyscarney brandyscarney added this to the @ionic/core 0.0.4 milestone Mar 19, 2018
@ionitron-bot ionitron-bot bot removed the triage label Mar 19, 2018
@brandyscarney brandyscarney changed the title Border between menu and content should have transparency v4 Color Issues Mar 20, 2018
brandyscarney added a commit that referenced this issue Mar 21, 2018
@ionitron-bot
Copy link

ionitron-bot bot commented Sep 1, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot unassigned aphex Sep 1, 2018
@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants