Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v4.0.0-beta.8] col sizing not working #15496

Closed
comino opened this issue Sep 7, 2018 · 2 comments
Closed

[v4.0.0-beta.8] col sizing not working #15496

comino opened this issue Sep 7, 2018 · 2 comments
Labels

Comments

@comino
Copy link

comino commented Sep 7, 2018

Bug Report

Ionic:

   ionic (Ionic CLI)          : 4.1.1 (/usr/local/lib/node_modules/ionic)
   Ionic Framework            : @ionic/angular 4.0.0-beta.8
   @angular-devkit/core       : 0.7.5
   @angular-devkit/schematics : 0.7.5
   @angular/cli               : 6.1.5
   @ionic/ng-toolkit          : 1.0.8
   @ionic/schematics-angular  : 1.0.6

Cordova:

   cordova (Cordova CLI) : 8.0.0
   Cordova Platforms     : browser 5.0.4
   Cordova Plugins       : cordova-plugin-ionic-keyboard 2.1.2, cordova-plugin-ionic-webview 2.1.0, (and 5 other plugins)

System:

   Android SDK Tools : 26.1.1 (/home/comino/Android/Sdk)
   NodeJS            : v10.9.0 (/usr/local/bin/node)
   npm               : 6.4.1
   OS                : Linux 4.18

Describe the Bug
The sizing columns don't seem to work anymore after upgrading to beta-7/8. The "size" attribute seems to be ignored. Having a col-4 and a col-8 leads to a 50%/50% row split.

note: My IDE linting claims, that attribute is not defined (even though I checked implementation and it seems it is ...)

Related Code
Example 1: inside ion-menu

    <ion-header no-border>
      <ion-toolbar color="primary" class="user-profile">
        <ion-grid>
          <ion-row align-items="center">
            <ion-col size="3">
              <div class="user-avatar">
                <img src="../assets/img/icon-white.svg">
              </div>
            </ion-col>
            <ion-col size="9">
              <ion-text class="no-margin bold text-white tenant-name">
                <div *ngIf="user"> {{ user.firstName }} {{ user.lastName }}</div>
              </ion-text>
            </ion-col>
          </ion-row>
        </ion-grid>
      </ion-toolbar>
    </ion-header>

Example 2:

  <ion-row *ngFor="let item of items" (click)="openPage(item.ID)">
    <ion-col class="status-card-body" size="8">
      <h2>{{item.description}}</h2>
      <ion-row class="item-boxes">
          <ion-col size="4">  {{item.list[1].value}}  </ion-col>
          <ion-col size="8">  {{item.list[0].value}}   </ion-col>
      </ion-row>
    </ion-col>
    <ion-col [class]="device.status.styleClass" size="4">
      <div class="status-icon">
        <ion-icon name="md-checkmark"></ion-icon>
      </div>
      <div class="status-card-statustext"> {{device.status.message}} </div>
    </ion-col>
  </ion-row>

Additional Context
It was working fine with ionic 4 beta (I think it was v5) and the issue was introduced while updating to beta-7. I must admit, that I also run the migration tool while updating dependencies and I might have introduced bugs fixing the breaking changes, but I can't find anything that can be related to this issue.

@ionitron-bot ionitron-bot bot added the triage label Sep 7, 2018
@comino comino changed the title [ionic-beta-8] col sizing not working [v4.0.0-beta.8] col sizing not working Sep 7, 2018
@mhartington
Copy link
Contributor

Closed via #15498

@ionitron-bot
Copy link

ionitron-bot bot commented Oct 7, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Oct 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants