Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ionic 4.0.0, beta 8] ion-col size doesn't work as col-X directive #15526

Closed
marticrespi opened this issue Sep 9, 2018 · 5 comments
Closed

Comments

@marticrespi
Copy link

Bug Report

Ionic Info
ionic (Ionic CLI) : 4.1.1 (C:\Users\XXX\AppData\Roaming\npm\node_modules\ionic)
Ionic Framework : @ionic/angular 4.0.0-beta.8
@angular-devkit/core : 0.7.5
@angular-devkit/schematics : 0.7.5
@angular/cli : 6.1.5
@ionic/ng-toolkit : 1.0.7
@ionic/schematics-angular : 1.0.5

Describe the Bug
The parameter size doesn't work as col directive in ionic 3.
2018-09-09_22h26_21

You can see two ion-col's inside an ion-row in ionic 3. The bigger tagged with col-9 and the smaller with col-3. They are placed well, respecting their expected size.

But in ionic 4, I have used size 9 or 10 (the second ion-col without size property as explained in http://ionic-docs.herokuapp.com/docs/layout/grid/) and they aren't placed as expected.

2018-09-09_22h32_57

Related Code
Code in v3

	<ion-row>
		<ion-col col-9>
			<h4>Promociones Especiales</h4>
		</ion-col>
		<ion-col col-3>
			<p (click)="ViewAll('promotions')">Ver todo</p>
		</ion-col>
	</ion-row>

Code in v4

		<ion-row>
			<ion-col size="10">
				<h4>Promociones Especiales</h4>
			</ion-col>
			<ion-col>
				<p (click)="ViewAll('promotions')">Ver todo</p>
			</ion-col>
		</ion-row>

Besides that, if you go at the link above in the example where explain the size, you can see that it's the same size than the others, it showed as wider but it's exactly the same size.

2018-09-09_22h37_05

Expected Behavior
Working as version 3.

@ionitron-bot ionitron-bot bot added the triage label Sep 9, 2018
@patwaswapnil
Copy link

Same problem here. It was working till beta 7 but stopped working when I updated to beta 8. Please address this issue.

@paulstelzer
Copy link
Contributor

paulstelzer commented Sep 10, 2018

This will be fixed in next beta release (i pushed a PR (#15498) what is merged already - issue #15495). So it will work then as expected:

  <ion-row>
    <ion-col size="10">
      <h4>Lorem ipsum title</h4>
      <p>Lorem ipsum dolor sit amet, consetetur sadipscing elitr, sed diam nonumy eirmod tempor invidunt ut labore et
        dolore magna aliquyam erat, sed diam voluptua. At vero eos et accusam et justo duo dolores et ea rebum. Stet
        clita kasd gubergren, no sea takimata sanctus est Lorem ipsum dolor sit amet. Lorem ipsum dolor sit amet,
        consetetur sadipscing elitr, sed diam nonumy eirmod tempor invidunt ut labore et dolore magna aliquyam erat,
        sed diam voluptua. At vero eos et accusam et justo duo dolores et ea rebum. Stet clita kasd gubergren, no sea
        takimata sanctus est Lorem ipsum dolor sit amet.</p>
    </ion-col>
    <ion-col>
      <h4>Lorem ipsum title</h4>
      <p>Lorem ipsum dolor sit amet, consetetur sadipscing elitr, sed diam nonumy eirmod tempor invidunt ut labore et
        dolore magna aliquyam erat, sed diam voluptua. At vero eos et accusam et justo duo dolores et ea rebum. Stet
        clita kasd gubergren, no sea takimata sanctus est Lorem ipsum dolor sit amet. Lorem ipsum dolor sit amet,
        consetetur sadipscing elitr, sed diam nonumy eirmod tempor invidunt ut labore et dolore magna aliquyam erat,
        sed diam voluptua. At vero eos et accusam et justo duo dolores et ea rebum. Stet clita kasd gubergren, no sea
        takimata sanctus est Lorem ipsum dolor sit amet.</p>
    </ion-col>
  </ion-row>

chrome_2018-09-10_09-40-15

Issue can be closed!

@woodstream
Copy link

woodstream commented Sep 10, 2018

@patwaswapnil I have found the ‘size‘ in ion-col is not work in beta8, and I roll-back to beta7, but someone had fixed it: #15496

@ionitron-bot ionitron-bot bot removed the triage label Sep 11, 2018
@brandyscarney
Copy link
Member

Thanks for the issue! I'm going to close this since it will be resolved in beta.9.

@ionitron-bot
Copy link

ionitron-bot bot commented Oct 11, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Oct 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants