-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: refresher not visible when content has fullscreen attribute #18714
bug: refresher not visible when content has fullscreen attribute #18714
Comments
Thanks! I created a CodePen of the bug here: https://codepen.io/liamdebeasi/pen/ewMdLg |
@liamdebeasi Has this been fixed? I still experience this issue with Ionic 5.0.5 when |
@liamdebeasi any chance of a fix for the refresher? I have the latest release of ionic v5 and still just see a blank space when pulling to refresh if ion-content has fullscreen="true". Makes for a terrible user experience as the user has no idea what they have done or what is happening. |
Can confirm |
Hello, maybe you can try to increase pullMin value. |
Will this be fixed in Ionic 6? |
I hope we see a fix for this in Ionic 6 ... |
Well, I just came across the issue by chance. I know that's not an elegant solution as custom ones will show over the content of the page but, while we wait for a definitive solution, overriding the following style in my global.scss and changing its default z-index from -1 to 1 (or greater) works for me: |
Hello, I have a similar error.
|
I have a problem with ion-refresher not displaying correctly inside ion-content, which has a fullscreen attribute too. I'm not the only one who has had this problem.
As a workaround, I had to reassign z-index to the ion-refresher class:
Steps to Reproduce
Ionic Info Ionic: Ionic CLI : 5.4.16 Capacitor: Capacitor CLI : 5.7.3 Cordova: Cordova CLI : 12.0.0 (cordova-lib@12.0.1) Utility: cordova-res : not installed System: NodeJS : v20.12.0 (C:\Program Files\nodejs\node.exe) |
Issue number: resolves #18714 --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> When the `ion-content` has the fullscreen attribute, the `ion-refresher` will be hidden while refreshing. This can be seen by dragging far enough to trigger it to snap back and refresh. The refresher ends up being hidden behind the background content element. https://github.com/ionic-team/ionic-framework/assets/13530427/27b5393b-dd31-44a5-b872-97709e3a0980 ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Set the `--offset-top` to `0px` for the background content element. This reflects the same behavior of when the content is not fullscreen. By setting this to `0px`, the refresher is visible while refreshing. - Added a private prop within refresher to keep track of whether `ion-content` is `fullscreen` or not. - Added test. Originally, I was going to update the `pullMin` and `pullMax` as agreed on from the investigation ticket. However, it ended up adding too much space between the refresher and the content. This is the reason why I decided to modify the background background instead. Otherwise, it wouldn't mimic the behavior when content doesn't have the `fullscreen` attribute. Example of what the spacing looked like: https://github.com/ionic-team/ionic-framework/assets/13530427/389cea62-48c1-4464-be47-44bc3b6c0315 ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer for more information. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> [Preview](https://ionic-framework-git-rou-4950-ionic1.vercel.app/src/components/refresher/test/fullscreen) How to test: 1. Navigate to the preview page 2. Use the browser's simulator to chose an iOS device (might need to refresh the page) 3. Drag the screen down 4. Verify that the refreshing text is shown 5. Use the browser's simulator to chose an Android device (might need to refresh the page) 6. Drag the screen down 7. Verify that the refreshing text is shown
Thanks for the issue! This has been resolved via PR #29608 and will be available in an upcoming release of Ionic. |
Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out. |
Bug Report
Ionic version:
[x] 4.x
Current behavior:
ion-refresher
is not visible whencontent
hasfullscreen
attribute.Expected behavior:
ion-refresher
should be visible when dragging content down, even ifcontent
has afullscreen
attribute.Steps to reproduce:
Related code:
It seems to be some kind of
z-index
issue, since adding a higher value shows the refresher:Other information:
Related issues:
#10490
ionic-team/ionic-v3#256
Ionic info:
The text was updated successfully, but these errors were encountered: