Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Checkbox touch target issue when there is a link in the text - A11y issue #23289

Closed
mastergogo opened this issue May 11, 2021 · 3 comments
Closed
Labels
package: core @ionic/core package type: bug a confirmed bug report

Comments

@mastergogo
Copy link

mastergogo commented May 11, 2021

Bug Report

Ionic version:
4.x
5.x

Current behavior:
if ion-checkbox has text and along with text if there is a link present, then touch target for the checkbox becomes very small, user cannot tap on the text to select the checkbox, also the link becomes inaccessible for the screen reader user. however, if the link is removed, then the user can select the checkbox by tapping on the text itself.

Expected behavior:
Users should be able to tap on the text to select the checkbox regardless of the link present or not as it provides a larger touch target.

Steps to reproduce:
I have added reproducible code below, there are two checkboxes, one with a link and one without it, you should be able to select the checkbox by tapping on the text itself, but that'll only happen on the checkbox without the link in it. Users should be able to select both the checkboxes just by tapping on the text, I had deployed the app to test this using capacitor.

<ion-item> <ion-checkbox color="primary"> </ion-checkbox> <ion-label class="ion-text-wrap" >please select the checkbox to agree to <a href="#">terms and conditions</a></ion-label> </ion-item> <ion-item> <ion-checkbox color="primary"> </ion-checkbox> <ion-label class="ion-text-wrap" >please select the checkbox to agree to terms and conditions</ion-label> </ion-item>

let me know if more info is needed to reproduce the issue.

@ionitron-bot ionitron-bot bot added the triage label May 11, 2021
@liamdebeasi liamdebeasi added package: core @ionic/core package type: bug a confirmed bug report labels May 11, 2021
@ionitron-bot ionitron-bot bot removed the triage label May 11, 2021
@liamdebeasi
Copy link
Contributor

Hi there,

We are proposing some changes to form components that seek to resolve this issue. We would love your feedback on these proposed changes! You can read more about the changes and leave comments here: #25660

@liamdebeasi
Copy link
Contributor

Hey there,

We recently merged some changes in 9d52e70 that should resolve this issue. These changes are part of the work I referenced in #25660.

This new architecture will be available in Ionic 7.0. We will have a beta period in the future where developers can test and provide feedback. Since the work to resolve this issue has been completed, I am going to close this. Let me know if you have any questions. Thanks!

@ionitron-bot
Copy link

ionitron-bot bot commented Feb 5, 2023

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Feb 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
package: core @ionic/core package type: bug a confirmed bug report
Projects
None yet
Development

No branches or pull requests

2 participants