-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: Popover arrow is rendered under the backdrop #28985
Comments
Thank you for the issue! I was able to replicate it using Firefox, Chrome, and Safari with a Mac. |
Hi, I would like to work on this issue 🙂 |
Update: I have verified that this issue is not being replicated within Ionic Framework. It's only happening within the Ionic docs site. |
After discussing with the team, the issue indeed lies within the Ionic Framework. |
Issue number: resolves #28985 --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> When a popover is being rendered in iOS mode, the arrow renders under the backdrop. ![Screenshot 2024-02-06 at 11 59 58 AM](https://github.com/ionic-team/ionic-framework/assets/13530427/b55f8868-4de3-4f52-8e79-650a40f8d5bd) ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - The arrow renders at the same level as the content. ![Screenshot 2024-02-06 at 11 59 51 AM](https://github.com/ionic-team/ionic-framework/assets/13530427/05c214ee-6ba7-4cad-b00e-9668dca23f73) ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#footer for more information. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> Credit [Sahil-B07](https://github.com/Sahil-B07) for providing the [fix](#28430). A new PR had to be created in order to update snapshots. --------- Co-authored-by: Sahil Bhor <92709590+Sahil-B07@users.noreply.github.com> --------- Co-authored-by: ionitron <hi@ionicframework.com>
Issue number: resolves #28985 --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> <!-- Please describe the current behavior that you are modifying. --> When a popover is being rendered in iOS mode, the arrow renders under the backdrop. ![Screenshot 2024-02-06 at 11 59 58 AM](https://github.com/ionic-team/ionic-framework/assets/13530427/b55f8868-4de3-4f52-8e79-650a40f8d5bd) <!-- Please describe the behavior or changes that are being added by this PR. --> - The arrow renders at the same level as the content. ![Screenshot 2024-02-06 at 11 59 51 AM](https://github.com/ionic-team/ionic-framework/assets/13530427/05c214ee-6ba7-4cad-b00e-9668dca23f73) - [ ] Yes - [x] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#footer for more information. --> <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> Credit [Sahil-B07](https://github.com/Sahil-B07) for providing the [fix](#28430). A new PR had to be created in order to update snapshots. --------- Co-authored-by: Sahil Bhor <92709590+Sahil-B07@users.noreply.github.com> Co-authored-by: ionitron <hi@ionicframework.com>
Thanks for the issue! This has been resolved via #28986 and will be available in an upcoming release of Ionic. |
Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out. |
Prerequisites
Ionic Framework Version
v7.x
Current Behavior
This issue only seems to reproduce on Mac
As seen in the Side and Alignment Demo, when the popover is presented in iOS the arrow is lighter than the popover container as a result of rendering under the backdrop.
Additionally, while hard to visibly see based on the background color, the arrow is not tight to the container and is ~1px offset from where it should render.
Expected Behavior
.popover-arrow
should be11
or greater.top
value are causing the arrow to render incorrectly. Flooring the value results in the correct display.Here is a modified example of the expected visual state:
Steps to Reproduce
Code Reproduction URL
No response
Ionic Info
N/A
Additional Information
Tested on Google Chrome: Version 113.0.5672.126 (Official Build) (arm64)
This issue is not captured in our visual regression tests: https://github.com/ionic-team/ionic-framework/blob/main/core/src/components/popover/test/arrow/popover.e2e.ts-snapshots/popover-arrow-ios-ltr-Mobile-Chrome-linux.png
The text was updated successfully, but these errors were encountered: