-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ionic/vue ionChange not catchable in a straightforward way since update #30170
Comments
I can confirm it. |
i can confirm it too. |
Same @ion-change in vue not triggered anymore after update from @ionic/vue 8.4.2 to 8.4.3 |
I can confirm this issue. Using: None of the events from input fields are being triggered, including: Specifically, these event listeners are not firing: @IonChange A workaround is to rewrite the Ionic event bindings using Vue events, e.g., via v-model. Has anyone found a proper fix for this? |
Oh, so I'm not crazy. |
Downgrading to 8.4.2 seems the only solution for now! |
Chiming in on this issue. I can confirm that Using Downgrading to v8.4.2 solves the issue. My setup |
Not really, you can always refactor your entire code to use the symbol instead (sarcasm) but that's what I did, and hopefully I can just leave it like that |
+1 @ionChange events are not fired anymore |
Seem like most of events not fired in version 8.4.3 |
Thank you for the issue! We're currently investigating this, along with all other related Vue issues introduced in version 8.4.3. |
Issue number: resolves #30206 resolves #30178 resolves #30177 resolves #30175 resolves #30170 --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? There have been plenty of issues reported in regards to Vue components failing to propagate events. It seems like when we updated the Vue output target and started to use the provided runtime code from the output target, we have changed the way how event names are computed. Ionic has used a custom wrapper for handling events that would kebab case event names. That is no longer needed and removing it fixes observed issues. Reproduction case working: https://stackblitz.com/edit/vj18czas-wdhzxjom?file=package.json ## What is the new behavior? We have received a fix for this in stenciljs/output-targets#617 which I hope will resolve this issue by updating the dependency. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer for more information. --> ## Other information Dev build: `8.4.4-dev.11741193800.14916f6f`
i can confirm it too. |
We'll have |
In my code I have to do, for example:
with "ion-change" being specified literally that way, to listen to said event. Neither
v-on:ionChange
norv-on:ion-change
(with shorthands et cetera) are working anymore.I noticed this after a dependency update that brought me to version 8.4.3 from version 8.4.1 - and also it went unnoticed because I personally only seldom use ionChange, relying most of the times on v-models.
(My project is https://github.com/NyaomiDEV/Ampersand if you want to know more)
Also, I was able to reproduce it minimally on StackBlitz: https://stackblitz.com/edit/vj18czas?file=src%2FApp.vue
The text was updated successfully, but these errors were encountered: