-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Description
Prerequisites
- I have read the Contributing Guidelines.
- I agree to follow the Code of Conduct.
- I have searched for existing issues that already report this problem, without success.
Ionic Framework Version
v8.x
Current Behavior
Using compareWith
with a property name leads to errors being thrown when the value is null
, which can happen in forms when there is no value yet, or when the value is being cleared. This is because the check is:
} else if (typeof compareWith === 'string') {
return currentValue[compareWith] === compareValue[compareWith];
If we then want to use allowEmptySelection
on a radio group, it doesn't work initially, because it doesn't use the compareWith
to see if the radio button should be unchecked and as the values are not equal by reference, it selects it again instead.
Expected Behavior
compareWith
must keep in mind null
values, as these are valid values in forms, meaning the value is explicitly empty, because undefined
is used for something else by Angular.
allowEmptySelection
must use the compareWith
to check if the selected radio button must be deselected, otherwise it doesn't work if the current value and the value of the radio button isn't equal in reference but equal by compareWith
property name.
Steps to Reproduce
- Go to the reproduction
- Wait for the application to load and see the list of foods, with the currently selected value added in the view.
- Click the currently selected radio button and see that it's still checked.
I couldn't find the console in Stackblitz, but when the current value is null
, you'll get an error there.
Code Reproduction URL
https://stackblitz.com/edit/nzwodvxm?file=src%2Fapp%2Fexample.component.ts
Ionic Info
[WARN] You are not in an Ionic project directory. Project context may be missing.
Ionic:
Ionic CLI : 5.4.16
Utility:
cordova-res : not installed
native-run : not installed
System:
NodeJS : v20.19.1
npm : 10.8.2
OS : macOS Unknown
I believe our setup is not following standards? There is cordova and ionic through Angular in the repo...
Additional Information
No response