Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: slides - emit events for slide change start and end #5301

Closed
brandyscarney opened this issue Feb 2, 2016 · 4 comments
Closed

feat: slides - emit events for slide change start and end #5301

brandyscarney opened this issue Feb 2, 2016 · 4 comments
Assignees
@brandyscarney
Milestone
2.0.0-beta.1

Comments

@brandyscarney
Copy link
Member

Similar to the change event
@brandyscarney brandyscarney self-assigned this Feb 2, 2016
@brandyscarney brandyscarney added this to the 2.0.0-beta.1 milestone Feb 3, 2016
brandyscarney added a commit that referenced this issue Feb 13, 2016
@brandyscarney
feat(slides): add slideChangeStart event output
736140c 
Didn’t add any event for `slideChangeEnd` because this already exists
as `change`.

closes #5301
brandyscarney added a commit that referenced this issue Feb 13, 2016
@brandyscarney
test(slides): added the slideChangeStart event to the intro test
a997a4d 
This will now change the navbar button text before the slide is shown.

References #5301
@brandyscarney brandyscarney mentioned this issue Feb 13, 2016
Closed
@brandyscarney
Copy link
Member Author

Implemented the slideChangeStart event but not the slideChangeEnd event because this already happens when the change event is emitted. I didn't want to have two ways of using the same event, may want to rethink the name of the change event.

@msprasad9
Copy link

msprasad9 commented Mar 17, 2017 •
edited
Loading

Ionic has ionSlideDidChange event when I changed form Slide 1 to Slide 2 while dragging a slide. But If I fail to move from Slide 1 to Slide 2 I couldn't find any event to capture. Can Any one help me how can I get that event. @brandyscarney @alexweber

@thetwosents
Copy link

^ Have same issue as above

@ionitron-bot
Copy link

ionitron-bot bot commented Sep 1, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@brandyscarney brandyscarney

Labels
None yet
Projects
None yet
Milestone
2.0.0-beta.1
Development

No branches or pull requests
3 participants
@thetwosents @brandyscarney @msprasad9