-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Item reordering issues #7142
Comments
- Small icon - Not opaque references #7142
@mlynch @adamdbradley all the issues have been fixed in the following commits: but "Icon should animate in instead of just appearing" is not that simple.
I think it is a perfect use case for the new animate hooks of angular 2, but I think we decided to wait until they are more mature, right? |
If the drag is cancelled and the item barely moves and doesn't actually reorder, indexes.to is set to -100 instead of the actual index. Checking if indexes.to < 0 isn't as intuitive as just checking if indexes.from == indexes.to. Agree? |
@djangojack 100% agree, it is a bug! can you please open an issue? |
@manucorporat done. #7307 |
There is a PR open to change the icon to the |
Reorder animation #7651 merged! |
#7450 merged! thanks @btroncone |
A few UX things with the new reorder.
See video for examples of all:
http://ionic-io-assets.s3.amazonaws.com/reorder.mov
The text was updated successfully, but these errors were encountered: