Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Item reordering issues #7142

Closed
4 tasks done
mlynch opened this issue Jun 30, 2016 · 8 comments
Closed
4 tasks done

Item reordering issues #7142

mlynch opened this issue Jun 30, 2016 · 8 comments
Assignees

Comments

@mlynch
Copy link
Contributor

mlynch commented Jun 30, 2016

A few UX things with the new reorder.

  • Icon is too big and too opaque (i.e. try grey instead of black). I know it's the wrong one but could make this one smaller in the meantime
  • Icon should animate in instead of just appearing
  • Can't reorder above the first one.
  • If the drag is canceled the element doesn't animate smoothly back

See video for examples of all:

http://ionic-io-assets.s3.amazonaws.com/reorder.mov

@manucorporat
Copy link
Contributor

@mlynch I think the point 3 was fixed here last night: here

I will check out tonight though :)

manucorporat added a commit that referenced this issue Jul 1, 2016
- Small icon
- Not opaque

references #7142
@manucorporat
Copy link
Contributor

@mlynch @adamdbradley all the issues have been fixed in the following commits:
f289ac6
8483a43
d993a1b

but "Icon should animate in instead of just appearing" is not that simple.

  • We can't use only CSS, but Animate for each one
  • What if the list has hundreds of items

I think it is a perfect use case for the new animate hooks of angular 2, but I think we decided to wait until they are more mature, right?

@lbickston
Copy link

If the drag is cancelled and the item barely moves and doesn't actually reorder, indexes.to is set to -100 instead of the actual index. Checking if indexes.to < 0 isn't as intuitive as just checking if indexes.from == indexes.to. Agree?

@manucorporat
Copy link
Contributor

@djangojack 100% agree, it is a bug! can you please open an issue?

@lbickston
Copy link

@manucorporat done. #7307

@brandyscarney
Copy link
Member

There is a PR open to change the icon to the reorder icon. Is this something we want to do? #7450

@manucorporat
Copy link
Contributor

manucorporat commented Aug 20, 2016

Reorder animation #7651 merged!
Thanks @mhartington

@manucorporat
Copy link
Contributor

manucorporat commented Aug 20, 2016

#7450 merged! thanks @btroncone
@mlynch closing issue... 👌

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants