Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ionic2 -bug(virtualscroll) - Virtual scroll does not work in modals #8142

Closed
zakton5 opened this issue Sep 20, 2016 · 4 comments
Closed

ionic2 -bug(virtualscroll) - Virtual scroll does not work in modals #8142

zakton5 opened this issue Sep 20, 2016 · 4 comments

Comments

@zakton5
Copy link
Contributor

zakton5 commented Sep 20, 2016

Short description of the problem:

When presenting a modal with a virtual scroll list, I receive the following error.


`VM658 zone.min.js:1 Unhandled Promise rejection: EXCEPTION: Error in ./SelectionModal class SelectionModal - inline template:16:16
ORIGINAL EXCEPTION: No provider for Content!
ORIGINAL STACKTRACE:
Error: DI Exception
    at NoProviderError.BaseException [as constructor] (https://npmcdn.com/@angular/core@2.0.0-rc.4/src/facade/exceptions.js:27:23)
    at NoProviderError.AbstractProviderError [as constructor] (https://npmcdn.com/@angular/core@2.0.0-rc.4/src/di/reflective_exceptions.js:43:16)
    at new NoProviderError (https://npmcdn.com/@angular/core@2.0.0-rc.4/src/di/reflective_exceptions.js:80:16)
    at ReflectiveInjector_._throwOrNull (https://npmcdn.com/@angular/core@2.0.0-rc.4/src/di/reflective_injector.js:786:19)
    at ReflectiveInjector_._getByKeyDefault (https://npmcdn.com/@angular/core@2.0.0-rc.4/src/di/reflective_injector.js:814:25)
    at ReflectiveInjector_._getByKey (https://npmcdn.com/@angular/core@2.0.0-rc.4/src/di/reflective_injector.js:777:25)
    at ReflectiveInjector_.get (https://npmcdn.com/@angular/core@2.0.0-rc.4/src/di/reflective_injector.js:586:21)
    at ElementInjector.get (https://npmcdn.com/@angular/core@2.0.0-rc.4/src/linker/element_injector.js:30:48)
    at ElementInjector.get (https://npmcdn.com/@angular/core@2.0.0-rc.4/src/linker/element_injector.js:30:48)
    at ReflectiveInjector_._getByKeyDefault (https://npmcdn.com/@angular/core@2.0.0-rc.4/src/di/reflective_injector.js:811:24)
ERROR CONTEXT:
[object Object] ; Zone: angular ; Task: Promise.then ; Value: ViewWrappedException {_wrapperMessage: "Error in ./SelectionModal class SelectionModal - inline template:16:16", _originalException: NoProviderError, _originalStack: "Error: DI Exception↵    at NoProviderError.BaseExc…@2.0.0-rc.4/src/di/reflective_injector.js:811:24)", _context: DebugContext, _wrapperStack: "Error: Error in ./SelectionModal class SelectionMo…ar@2.0.0-beta.10/bundles/ionic.system.js:16259:64"} undefined`

Which Ionic Version?
2.0@beta.10 and 11

Plunker that shows an example of your issue

http://plnkr.co/edit/kRTqAU33ZBgflrI5bGJu?p=preview

@marianocodes
Copy link

Not sure if this is the best solution but wrapping your modal component into a ion-content tag it will show the modal with the virtual scroll

http://plnkr.co/edit/bTWB1l74SEKJ3qHAjcOH?p=preview

@zakton5
Copy link
Contributor Author

zakton5 commented Sep 26, 2016

Well that removes the error and it loads. However, there are some serious display issues with virtual scroll if there are more items in the list. Hopefully it is fixed in the next beta

@zakton5
Copy link
Contributor Author

zakton5 commented Oct 11, 2016

Alright, so at this point I have it loading in a modal. But when I scroll down the list the other items do not load. It seems like the scroll event is not getting fired

@jgw96
Copy link
Contributor

jgw96 commented Nov 4, 2016

Hello, thanks for using Ionic! Since the original issue was solved by adding ion-content, which should be there, I am going to close this issue for now. Please open another issue for any further issues. Thanks!

@jgw96 jgw96 closed this as completed Nov 4, 2016
@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants