Ionic v2 nightly-build: Loading => Promise exception

[peterpeterparker]

Ionic2 version: 2.0.0-rc.3-201612100458

Following code taken from my app:

navigateToDetail() {
    let loading = this.loadingController.create({
        dismissOnPageChange: true
    });

    loading.present().then(() => {
        this.navController.push(DetailsPage, {
            stuff: this.stuff
        });
    });
}

will produce following errors the very first time the page is pushed:

error_handler.js:53 Error: Uncaught (in promise): false
at s (polyfills.js:3)
at s (polyfills.js:3)
at polyfills.js:3
at t.invokeTask (polyfills.js:3)
at Object.onInvokeTask (ng_zone.js:227)
at t.invokeTask (polyfills.js:3)
at e.runTask (polyfills.js:3)
at i (polyfills.js:3)
at HTMLElement.invoke (polyfills.js:3)

Tried the same above code in other places in my app, also tried to used var self=this didn't change it, nothing helped. Same code with official RC.3 doesn't produce any errors.

P.S.: Everything is compiling fine. Angular is up-to-date 2.2.1. Node_modules was deleted and installed again.

P.P.S.: Just tried to remove the "dismissOnPageChange: true" part. Of course the loading stay pending but except that everything went fine, new page is pushed, no error in the stacktrace

[ataraxus]

@peterpeterparker it would be helpfull if you provide an ionic info output. I'm pretty sure I do use also navcontroller in a loader. But I'll double check it later.

[peterpeterparker]

here you go:

Your system information:

Cordova CLI: 6.3.1
Ionic Framework Version: 2.0.0-rc.3-201612100458
Ionic CLI Version: 2.1.12
Ionic App Lib Version: 2.1.7
Ionic App Scripts Version: 0.0.46
ios-deploy version: 1.8.6
ios-sim version: 5.0.8
OS: macOS Sierra
Node Version: v7.0.0
Xcode version: Xcode 8.0 Build version 8A218a

[peterpeterparker]

@ataraxus were you able to reproduce this ugly problem with the nightly-build?

[ataraxus]

no issues on my side:

  open(page) {
    let gotoPage;
    switch (page) {
      case 'quiz':
        gotoPage = QuizStartPage;
        break;
      case 'cards':
        gotoPage = CardsStartPage;
        break;
      case 'glossary':
        gotoPage = GlossaryPage;
        break;
      case 'highscore':
        gotoPage = HighScorePage;
        break;
      default: return;
    }
    let loader = this.loadingCtrl.create({
      content: 'Bitte warten...',
      dismissOnPageChange : true
    });
    loader.present().then(() => {
      this.navCtrl.push(gotoPage);
    });
  }

Your system information:

 ordova CLI: 6.3.1
Ionic Framework Version: 2.0.0-rc.3-201612062256
Ionic CLI Version: 2.1.13
Ionic App Lib Version: 2.1.7
Ionic App Scripts Version: 0.0.46
ios-deploy version: Not installed
ios-sim version: Not installed
OS: Windows 7
Node Version: v6.9.1
Xcode version: Not installed

[peterpeterparker]

Crazy. Same code here. Then I thought maybe the problem comes from my node version, I tried then with node 7.0.0, 7.2.1 and 6.9.1...nope, always face the error.

But I just notice, @ataraxus, won't you mind trying with the very last nightly-build? I just noticed mine is more recent...also could you display me your package.json, maybe I forgot something?

Really appreciate your help on that

[peterpeterparker]

I could reproduce the problem with the starter app using the nightly build by just adding a super simple load controller + push page. I just put the code on GitHub.

https://github.com/peterpeterparker/testLoadPush.git

@jgw96 or ionic team, won't you mind having a look before releasing RC.4 ... it's so less code I really don't know what I miss or what's wrong with my configuration...but if I'm not wrong, that could be a good quality check on the RC.4

Ionic info:

Your system information:

Cordova CLI: 6.3.1
Ionic Framework Version: 2.0.0-rc.3-201612122136
Ionic CLI Version: 2.1.12
Ionic App Lib Version: 2.1.7
Ionic App Scripts Version: 0.0.45
ios-deploy version: 1.8.6
ios-sim version: 5.0.8
OS: macOS Sierra
Node Version: v6.9.1
Xcode version: Xcode 8.0 Build version 8A218a

Chrome up-to-date

With node 6.9.1 same problem

[jsayol]

I stumbled upon this too so I did some digging, and the problem seems to be with dismissing a LoadingController when the dismissOnPageChange option is set to true. This is independent of NavController, any way of dismissing the LoadingController will trigger the exception. For example, a simple way to reproduce:

this.loading = this.loadingCtrl.create({dismissOnPageChange: true});
this.loading.present().then(() => this.loading.dismiss());

Edit: dismissing a LoadingController that has the dismissOnPageChange option is triggering a App.viewDidLeave which in turn triggers the routine to dismiss any views that have the dismissOnPageChange option, including the one that was just dismissed.

There should be a check here to make sure the view hasn't already been dismissed, but I don't see any relevant property in ViewController.

[peterpeterparker]

@jsayol thx for digging and adding your informations, so happy to hear that I'm not the only one facing that problem ;) I edited the title of the issue to make it more general.

[jsayol]

Ok, got it. Adding a .catch() when dismissing prevents the unhandled exception. The fix is easy, just change the line here to this:

view.dismiss().catch(() => {});

I'll create the PR.