Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(input): show clearInput on inputs with ngModel/formControlName #10121

Merged
merged 1 commit into from
Jan 23, 2017
Merged

fix(input): show clearInput on inputs with ngModel/formControlName #10121

merged 1 commit into from
Jan 23, 2017

Conversation

brandyscarney
Copy link
Member

If the input has a formControlName or ngModel on it then onChange is not called so checkHasValue doesn't get called. This PR calls checkHasValue so that the clear input will work.

Also adds an input without ngModel/formControlName and inputs with formControlName to the clear-input test

Fixes #9077

@brandyscarney brandyscarney mentioned this pull request Jan 21, 2017
Closed
@brandyscarney brandyscarney requested a review from jgw96 January 21, 2017 01:36
@adamdbradley adamdbradley merged commit 7a6ba2d into master Jan 23, 2017
@adamdbradley adamdbradley added this to the 2.0.0-rc.6 milestone Jan 23, 2017
@brandyscarney brandyscarney deleted the fix-clear-input branch January 23, 2017 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgw96 jgw96 Awaiting requested review from jgw96

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0-rc.6
Development

Successfully merging this pull request may close these issues.
2 participants
@brandyscarney @adamdbradley