fix(select): make floating labels work for ion-select #10770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manucorporat
suggested changes
Mar 15, 2017
| @@ -65,7 +65,3 @@ ion-label[floating] { | |||
|
|
|||
| max-width: 100%; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
This CSS rule was forcing the floating label to always "float". It was needed because floating labels only float when the ion-item has input-has-value class. Now that it's being set by the ion-select, there's no need to force it.
|
Once I fixed I think that CSS rule was added as a workaround because ion-select didn't support |
|
Merged! thank you very much for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
This makes floating labels work with ion-select, instead of behaving like stacked labels.
Changes proposed in this pull request:
Ionic Version: 2.x
Fixes: #10751