Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(toggle): RTL fix for toggle #11824

Merged
merged 7 commits into from
Jun 9, 2017
Merged

Conversation

sijav
Copy link
Contributor

@sijav sijav commented May 28, 2017

Short description of what this resolves:

This will fix bugs of toggle component while on RTL mode

Changes proposed in this pull request:

  • fix the transform translate3d when on RTL
  • fix the toggle gesture when on RTL

Ionic Version: 3.x

Fixes: #11211

@AmitMY
Copy link
Contributor

AmitMY commented May 28, 2017

@sijav Looks great. Most SCSS changes will need to be reverted (only transition is ok to stay), as they are covered in a mixin that I hope they'll merge this week. #11649

@sijav
Copy link
Contributor Author

sijav commented May 28, 2017

@AmitMY Oh perfect!

@AmitMY
Copy link
Contributor

AmitMY commented Jun 7, 2017

Ok so preparing you in advance: remove all of the scss changes, and this is 2nd priority in my list (after transform mixin)

@sijav
Copy link
Contributor Author

sijav commented Jun 7, 2017

@AmitMY Ok no problem I'll wait for a mixin on this

@AmitMY
Copy link
Contributor

AmitMY commented Jun 7, 2017

@sijav No need to wait, just remove all of the scss changes, so it can get merged immediately after transform

@manucorporat manucorporat merged commit 344589a into ionic-team:master Jun 9, 2017
@sijav sijav deleted the rtl-fix-toggle branch June 16, 2017 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants