feat(snapshot): build all tests into a single app #11910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Complete missing defaults for animated and showCancelButton.
* docs(api-tabs): improved typo * Update tab.ts
* docs(api-slides): improve typo * Update slides.ts
* docs(api-checkbox): renamed Angular 2 to Angular * Update checkbox.ts
* docs(api-checkbox): improve typo * Update chip.ts
|
This is so awesome! 🎉 |
|
@brandyscarney Don't get too excited! Still need to figure out how to run protractor on it, with the correct tests for each app (so snapshot can use this by opening each app and running e2e.ts of that app) |
AmitMY
added a commit
to AmitMY/ionic
that referenced
this pull request
Jun 6, 2017
* fix(lint): unused import * fix(searchbar): caret moving to the end when typing * refactor(template): fix component template (ionic-team#11839) fix ionic-team#11838 * chore(issue-template): change link to new org name * docs(github): rename driftyco references to ionic-team * fix(toolbar): use the correct contrast color for MD toolbar fixes ionic-team#11848 * docs(searchbar): add default values for inputs (ionic-team#11856) Complete missing defaults for animated and showCancelButton. * docs(tabs): rename Angular 2 to Angular (ionic-team#11837) * docs(tabs): change double quotes to single quotes (ionic-team#11836) * docs(api-tabs): improved typo * Update tab.ts * docs(slides): change double quotes to single quotes (ionic-team#11835) * docs(api-slides): improve typo * Update slides.ts * docs(platform): change double quotes to single quotes (ionic-team#11834) * docs(nav-controller): add type to usage example (ionic-team#11833) * docs(util): hide normalizeURL (ionic-team#11735) * docs(checkbox): rename Angular 2 to Angular (ionic-team#11831) * docs(api-checkbox): renamed Angular 2 to Angular * Update checkbox.ts * docs(checkbox): improve usage example (ionic-team#11832) * docs(api-checkbox): improve typo * Update chip.ts * docs(menu): update menu-controller link Closes ionic-team#11877. Closes ionic-team/ionic-site#1129 * feat(snapshot): init new "components" for global testing * feat(snapshot): add app component * feat(snapshot): add assistive touch * feat(snapshot): add more components * feat(snapshot): add more components * fix(snapshot): add trailing line * fix(snapshot): remove not working tests * fix(snapshot): correct name of group
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needs to be integrated into the snapshot, so it will be lightning fast
Short description of what this resolves:
50 minutes (or really 100 if you want rtl, 200 if you want dark theme, etc...), reduced to 1 minute for everything
Changes proposed in this pull request:
gulp e2e.watch --f=snapshot/basicOops did a bad rebase, squash all commits :)
Ionic Version: 3.x