Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default values for ion-view hide-back-button and hide-nav-bar attributes #1216

Closed
wants to merge 1 commit into from
Closed

Add default values for ion-view hide-back-button and hide-nav-bar attributes #1216

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions js/angular/directive/view.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,9 @@
* ```
*
* @param {string=} title The title to display on the parent {@link ionic.directive:ionNavBar}.
* @param {boolean=} hideBackButton Whether to hide the back button on the parent
* @param {boolean=} hideBackButton Whether to hide the back button on the parent (default false)
* {@link ionic.directive:ionNavBar} by default.
* @param {boolean=} hideNavBar Whether to hide the parent
* @param {boolean=} hideNavBar Whether to hide the parent (default false)
* {@link ionic.directive:ionNavBar} by default.
*/
IonicModule
Expand All @@ -39,6 +39,8 @@ IonicModule
compile: function(tElement, tAttrs, transclude) {
tElement.addClass('pane');
tElement[0].removeAttribute('title');
tAttrs.hideBackButton = tAttrs.hideBackButton || false;
tAttrs.hideNavBar = tAttrs.hideNavBar || false;

return function link($scope, $element, $attr, navBarCtrl) {
if (!navBarCtrl) {
Expand Down